Skip to content

Inherit ServerError from Transport::Error instead of StandardError #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mlangenberg wants to merge 1 commit into from
Closed

Inherit ServerError from Transport::Error instead of StandardError #100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion elasticsearch-transport/lib/elasticsearch/transport/transport/errors.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ class SnifferTimeoutError < Timeout::Error; end

# Elasticsearch server error (HTTP status 5xx)
#
class ServerError < StandardError; end
class ServerError < Error; end

module Errors; end

Expand Down
5 changes: 5 additions & 0 deletions elasticsearch-transport/test/unit/transport_base_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,4 +452,9 @@ def initialize(*); end
end
end

context "errors" do
should "raise highest-level Error exception for any ServerError" do
assert_kind_of Elasticsearch::Transport::Transport::Error, Elasticsearch::Transport::Transport::ServerError.new
end
end
end