[ML] Correctly handle empty inputs in chunkedInfer() #138632
Merged
+558
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
DonalEvans
commented
Nov 26, 2025
DonalEvans
commented
- Add method to allow services that implement SenderService to indicate whether they support chunked inference
- Return immediately if the input list is empty for services that support chunked inference
- Throw exception if the input list is empty for services that do not support chunked inference, to maintain existing behaviour
- Add tests for all services that implement doChunkedInfer()
- Update DeepSeekServiceTests for new error message
- Add method to allow services that implement SenderService to indicate whether they support chunked inference - Return immediately if the input list is empty for services that support chunked inference - Throw exception if the input list is empty for services that do not support chunked inference, to maintain existing behaviour - Add tests for all services that implement doChunkedInfer() - Update DeepSeekServiceTests for new error message
DonalEvans
added
>bug
:ml
Collaborator
|
Pinging @elastic/ml-core (Team:ML) |
Collaborator
|
Hi @DonalEvans, I've created a changelog YAML for you. |
wwang500
pushed a commit
that referenced
this pull request
Nov 28, 2025
- Add method to allow services that implement SenderService to indicate whether they support chunked inference - Return immediately if the input list is empty for services that support chunked inference - Throw exception if the input list is empty for services that do not support chunked inference, to maintain existing behaviour - Add tests for all services that implement doChunkedInfer() - Update DeepSeekServiceTests for new error message (cherry picked from commit f70dbb8)
wwang500
added a commit
that referenced
this pull request
Nov 28, 2025
* [ML] Correctly handle empty inputs in chunkedInfer() (#138632) - Add method to allow services that implement SenderService to indicate whether they support chunked inference - Return immediately if the input list is empty for services that support chunked inference - Throw exception if the input list is empty for services that do not support chunked inference, to maintain existing behaviour - Add tests for all services that implement doChunkedInfer() - Update DeepSeekServiceTests for new error message (cherry picked from commit f70dbb8) * fix JinaAI tests due to the conflict --------- Co-authored-by: Donal Evans <donal.evans@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.