Skip to content

[ML] Correctly handle empty inputs in chunkedInfer() (#138632) #138782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 28, 2025
Merged

[ML] Correctly handle empty inputs in chunkedInfer() (#138632) #138782

merged 2 commits into from
Nov 28, 2025
+558 −8

Conversation

@wwang500
Copy link

@wwang500 wwang500 commented Nov 28, 2025

A copy of #138632

@DonalEvans @wwang500
[ML] Correctly handle empty inputs in chunkedInfer() (#138632)
8af6e78 
- Add method to allow services that implement SenderService to indicate
  whether they support chunked inference
- Return immediately if the input list is empty for services that
  support chunked inference
- Throw exception if the input list is empty for services that do not
  support chunked inference, to maintain existing behaviour
- Add tests for all services that implement doChunkedInfer()
- Update DeepSeekServiceTests for new error message

(cherry picked from commit f70dbb8)
@elasticsearchmachine elasticsearchmachine added serverless-linked Added by automation, don't add manually needs:triage Requires assignment of a team area label labels Nov 28, 2025
@wwang500 wwang500 self-assigned this Nov 28, 2025
@wwang500 wwang500 requested a review from jimczi November 28, 2025 20:13
@wwang500 wwang500 added :ml Machine learning v9.3.0 labels Nov 28, 2025
@elasticsearchmachine elasticsearchmachine added the Team:ML Meta label for the ML team label Nov 28, 2025
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Nov 28, 2025

Pinging @elastic/ml-core (Team:ML)

@elasticsearchmachine elasticsearchmachine removed the needs:triage Requires assignment of a team area label label Nov 28, 2025
@wwang500 wwang500 added >bug needs:triage Requires assignment of a team area label and removed Team:ML Meta label for the ML team labels Nov 28, 2025
@elasticsearchmachine elasticsearchmachine added Team:ML Meta label for the ML team and removed needs:triage Requires assignment of a team area label labels Nov 28, 2025
@wwang500
Copy link
Author

wwang500 commented Nov 28, 2025

Some bwc tests fail for this PR, which are expected imo.

  • The same BWC tests failed in last patch PR
  • The failing reason has been stated in this comments
  • The other recent patch PR has the same failure.

I am going to merge with this: Merge without waiting for requirements to be met (bypass rules)

@wwang500 wwang500 merged commit 0aa383b into patch/serverless-fix Nov 28, 2025
32 of 43 checks passed
@wwang500 wwang500 deleted the ww_patch_for_incident_2298 branch November 28, 2025 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jimczi jimczi jimczi approved these changes

@dan-rubinstein dan-rubinstein Awaiting requested review from dan-rubinstein

Assignees

@wwang500 wwang500

Labels

>bug :ml Machine learning serverless-linked Added by automation, don't add manually Team:ML Meta label for the ML team v9.3.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wwang500 @elasticsearchmachine @jimczi @DonalEvans