Skip to content

Stop iterating on sub readers if the parent is found in TopChildrenQuery #1843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Stop iterating on sub readers if the parent is found in TopChildrenQuery #1843

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 36 additions & 27 deletions src/main/java/org/elasticsearch/index/search/child/TopChildrenQuery.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,34 +134,43 @@ public void processResults(TopDocs topDocs, SearchContext context) {
// no parent found
continue;
}

// now go over and find the parent doc Id and reader tuple
for (IndexReader indexReader : context.searcher().subReaders()) {
int parentDocId = context.idCache().reader(indexReader).docById(parentType, parentId);
if (parentDocId != -1 && !indexReader.isDeleted(parentDocId)) {
// we found a match, add it and break

TIntObjectHashMap<ParentDoc> readerParentDocs = parentDocsPerReader.get(indexReader.getCoreCacheKey());
if (readerParentDocs == null) {
readerParentDocs = new TIntObjectHashMap<ParentDoc>();
parentDocsPerReader.put(indexReader.getCoreCacheKey(), readerParentDocs);
}

ParentDoc parentDoc = readerParentDocs.get(parentDocId);
if (parentDoc == null) {
numHits++; // we have a hit on a parent
parentDoc = new ParentDoc();
parentDoc.docId = parentDocId;
parentDoc.count = 1;
parentDoc.maxScore = scoreDoc.score;
parentDoc.sumScores = scoreDoc.score;
readerParentDocs.put(parentDocId, parentDoc);
} else {
parentDoc.count++;
parentDoc.sumScores += scoreDoc.score;
if (scoreDoc.score > parentDoc.maxScore) {
parentDoc.maxScore = scoreDoc.score;
}
}
int parentReaderIndex = 0;
int parentDocId = -1;
IndexReader parentIndexReader = null;
while (parentDocId == -1 && parentReaderIndex < context.searcher().subReaders().length) {
parentIndexReader = context.searcher().subReaders()[parentReaderIndex++];
parentDocId = context.idCache().reader(parentIndexReader).docById(parentType, parentId);
if (parentDocId != -1 && parentIndexReader.isDeleted(parentDocId)) {
parentDocId = -1;
}
}

if (parentDocId == -1) {
continue;
}

TIntObjectHashMap<ParentDoc> readerParentDocs = parentDocsPerReader.get(parentIndexReader.getCoreCacheKey());
if (readerParentDocs == null) {
readerParentDocs = new TIntObjectHashMap<ParentDoc>();
parentDocsPerReader.put(parentIndexReader.getCoreCacheKey(), readerParentDocs);
}

ParentDoc parentDoc = readerParentDocs.get(parentDocId);
if (parentDoc == null) {
numHits++; // we have a hit on a parent
parentDoc = new ParentDoc();
parentDoc.docId = parentDocId;
parentDoc.count = 1;
parentDoc.maxScore = scoreDoc.score;
parentDoc.sumScores = scoreDoc.score;
readerParentDocs.put(parentDocId, parentDoc);
} else {
parentDoc.count++;
parentDoc.sumScores += scoreDoc.score;
if (scoreDoc.score > parentDoc.maxScore) {
parentDoc.maxScore = scoreDoc.score;
}
}
}
Expand Down