Port more gradle build logic from groovy to java #70247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breskeby
added
:Delivery/Build
breskeby
changed the title
breskeby
changed the title
- In general we want to move all production build logic to java - this is an incremental step towards that goal.
breskeby
force-pushed
the
port-build-logic-java
branch
from
6cb4a7e to
74aae2d
Compare
Collaborator
|
Pinging @elastic/es-delivery (Team:Delivery) |
pugnascotia
reviewed
Mar 11, 2021
| throw new InvalidUserDataException("classname is a required setting for esplugin"); | ||
| } | ||
|
|
||
| Map<String, Object> map = new LinkedHashMap<>(12); |
Contributor
There was a problem hiding this comment.
Does this need to be a LinkedHashMap?
pugnascotia
reviewed
Mar 11, 2021
| output.append("\n\n"); | ||
| // This is a map rather than a set so that the sort order is the 3rd | ||
| // party component names, unaffected by the full path to the various files | ||
| final Map<String, File> seen = new TreeMap<String, File>(); |
Contributor
There was a problem hiding this comment.
Tiny nit-pick:
Suggested change
| final Map<String, File> seen = new TreeMap<String, File>(); | |
| final Map<String, File> seen = new TreeMap<>(); |
pugnascotia
reviewed
Mar 11, 2021
buildSrc/src/main/java/org/elasticsearch/gradle/NoticeTask.java
Outdated
Show resolved
Hide resolved
pugnascotia
reviewed
Mar 11, 2021
buildSrc/src/main/java/org/elasticsearch/gradle/plugin/PluginBuildPlugin.java
Outdated
Show resolved
Hide resolved
pugnascotia
approved these changes
Mar 11, 2021
Contributor
pugnascotia
left a comment
pugnascotia
left a comment
There was a problem hiding this comment.
LGTM, couple of minor comments that you could ignore.
Co-authored-by: Rory Hunter <pugnascotia@users.noreply.github.com>
Co-authored-by: Rory Hunter <pugnascotia@users.noreply.github.com>
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Apr 14, 2021
* Port more plugins from groovy to java - In general we want to move all production build logic to java - this is an incremental step towards that goal.
breskeby
added a commit
that referenced
this pull request
Apr 14, 2021
…) (#71673) - Port more plugins from groovy to java - In general we want to move all production build logic to java - this is an incremental step towards that goal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.