Reintroduce client jar conventions for plugin projects #71719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark-vieira
added
>non-issue
:Delivery/Build
Collaborator
|
Pinging @elastic/es-delivery (Team:Delivery) |
breskeby
approved these changes
Apr 15, 2021
Contributor
breskeby
left a comment
breskeby
left a comment
There was a problem hiding this comment.
somehow that flipped through in my former PR ¯_(ツ)_/¯
thanks for fixing.
Contributor
|
merging as we're waiting for daily snapshots back to green |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When #70247 was merged the logic for handling "client jars" in the 7.x branches was mistakenly removed. This pull request adds this logic back so that the artifacts for plugins use the correct
-clientsuffix convention. FYI, the notion of "client jars" was removed in 8.0 which is why this doesn't exist inmaster.