Make the purple palette available#9383
Conversation
94ac71c to
66337c7
Compare
1087ced to
9c52ee5
Compare
9c52ee5 to
959027d
Compare
JoseLuisGJ
left a comment
There was a problem hiding this comment.
LGTM @weronikaolejniczak thanks 🚀
|
ℹ️ The PR description lists |
Oh, absolutely, thanks for the catch! That was the state from the reverted commit adding tokens to |
b7107e6 to
d65f81c
Compare
d65f81c to
b4198fa
Compare
e65344d to
986e757
Compare
|
Thank you for the thorough review, @JoseLuisGJ and @mgadewoll! 🙏🏻 I addressed all the feedback, let me know if it's all as expected. |
packages/website/docs/getting-started/theming/tokens/colors/data_vis_colors_table.tsx
Show resolved
Hide resolved
💚 Build SucceededHistory
|
💚 Build Succeeded
History
|
mgadewoll
left a comment
There was a problem hiding this comment.
🟢 Code changes are looking good and the updated docs as well. Thanks for the patience on aligning the required changes. Nice work!
related to elastic/eui#9383
## Dependency updates - `@elastic/eui` - v113.0.0 ⏩ v113.1.0 - `@elastic/eui-theme-borealis` - v6.0.0 ⏩ v6.1.0 --- ## Changes | Commit | Change | Teams (Code Owner) | | :--- | :--- | :--- | | 18ef117 | Update snapshots, new Assistance color tokens ([#9383](elastic/eui#9383)) | @elastic/kibana-security | | 3fad87f | Update snapshots, new `aria-expanded` attribute added to button triggers of `EuiPopover` ([#9381](elastic/eui#9381)) | @elastic/appex-sharedux, @elastic/kibana-visualizations, @elastic/kibana-data-discovery | | cc9e096 | Update snapshots, remove `aria-controls` now handled by `EuiPopover` directly ([#9381](elastic/eui#9381)) | @elastic/kibana-security | ## Package updates ### `@elastic/eui` [v113.1.0](https://github.com/elastic/eui/releases/tag/v113.1.0) - Added `data-test-subj` attributes to `EuiFlyoutMenu` elements: back button, history dropdown, and history items. ([#9400](elastic/eui#9400)) - Added new assistance tokens: ([#9383](elastic/eui#9383)) - `euiTheme.colors.backgroundFilledAssistance` - `euiTheme.colors.backgroundLightAssistance` - `euiTheme.colors.backgroundBaseAssistance` - `euiTheme.components.buttons.backgroundAssistanceHover`, - `euiTheme.components.buttons.backgroundFilledAssistanceHover` - `euiTheme.colors.backgroundBaseInteractiveHoverAssistance` - `euiTheme.colors.borderStrongAssistance` - `euiTheme.colors.borderBaseAssistance` - `euiTheme.colors.textAssistance` - `euiTheme.colors.vis.euiColorVisAssistance` - `euiTheme.colors.severity.assistance` - `euiTheme.colors.vis.euiColorVis10` - `euiTheme.colors.vis.euiColorVis11` - `euiTheme.colors.vis.euiColorVisText10` - `euiTheme.colors.vis.euiColorVisText11` - Updated purple color palette shades 30-60 to slightly lighter values ([#9383](elastic/eui#9383)) **Accessibility** - Adds `aria-expanded` and `aria-controls` to the `EuiPopover` trigger button to improve screen reader context ([#9381](elastic/eui#9381)) ### `@elastic/eui-theme-borealis` v6.1.0 - Added new assistance tokens: ([#9383](elastic/eui#9383)) - `euiTheme.colors.backgroundFilledAssistance` - `euiTheme.colors.backgroundLightAssistance` - `euiTheme.colors.backgroundBaseAssistance` - `euiTheme.components.buttons.backgroundAssistanceHover`, - `euiTheme.components.buttons.backgroundFilledAssistanceHover` - `euiTheme.colors.backgroundBaseInteractiveHoverAssistance` - `euiTheme.colors.borderStrongAssistance` - `euiTheme.colors.borderBaseAssistance` - `euiTheme.colors.textAssistance` - `euiTheme.colors.vis.euiColorVisAssistance` - `euiTheme.colors.severity.assistance` - `euiTheme.colors.vis.euiColorVis10` - `euiTheme.colors.vis.euiColorVis11` - `euiTheme.colors.vis.euiColorVisText10` - `euiTheme.colors.vis.euiColorVisText11` - Updated purple color palette shades 30-60 to slightly lighter values ([#9383](elastic/eui#9383))
## Dependency updates - `@elastic/eui` - v113.0.0 ⏩ v113.1.0 - `@elastic/eui-theme-borealis` - v6.0.0 ⏩ v6.1.0 --- ## Changes | Commit | Change | Teams (Code Owner) | | :--- | :--- | :--- | | 18ef117 | Update snapshots, new Assistance color tokens ([elastic#9383](elastic/eui#9383)) | @elastic/kibana-security | | 3fad87f | Update snapshots, new `aria-expanded` attribute added to button triggers of `EuiPopover` ([elastic#9381](elastic/eui#9381)) | @elastic/appex-sharedux, @elastic/kibana-visualizations, @elastic/kibana-data-discovery | | cc9e096 | Update snapshots, remove `aria-controls` now handled by `EuiPopover` directly ([elastic#9381](elastic/eui#9381)) | @elastic/kibana-security | ## Package updates ### `@elastic/eui` [v113.1.0](https://github.com/elastic/eui/releases/tag/v113.1.0) - Added `data-test-subj` attributes to `EuiFlyoutMenu` elements: back button, history dropdown, and history items. ([elastic#9400](elastic/eui#9400)) - Added new assistance tokens: ([elastic#9383](elastic/eui#9383)) - `euiTheme.colors.backgroundFilledAssistance` - `euiTheme.colors.backgroundLightAssistance` - `euiTheme.colors.backgroundBaseAssistance` - `euiTheme.components.buttons.backgroundAssistanceHover`, - `euiTheme.components.buttons.backgroundFilledAssistanceHover` - `euiTheme.colors.backgroundBaseInteractiveHoverAssistance` - `euiTheme.colors.borderStrongAssistance` - `euiTheme.colors.borderBaseAssistance` - `euiTheme.colors.textAssistance` - `euiTheme.colors.vis.euiColorVisAssistance` - `euiTheme.colors.severity.assistance` - `euiTheme.colors.vis.euiColorVis10` - `euiTheme.colors.vis.euiColorVis11` - `euiTheme.colors.vis.euiColorVisText10` - `euiTheme.colors.vis.euiColorVisText11` - Updated purple color palette shades 30-60 to slightly lighter values ([elastic#9383](elastic/eui#9383)) **Accessibility** - Adds `aria-expanded` and `aria-controls` to the `EuiPopover` trigger button to improve screen reader context ([elastic#9381](elastic/eui#9381)) ### `@elastic/eui-theme-borealis` v6.1.0 - Added new assistance tokens: ([elastic#9383](elastic/eui#9383)) - `euiTheme.colors.backgroundFilledAssistance` - `euiTheme.colors.backgroundLightAssistance` - `euiTheme.colors.backgroundBaseAssistance` - `euiTheme.components.buttons.backgroundAssistanceHover`, - `euiTheme.components.buttons.backgroundFilledAssistanceHover` - `euiTheme.colors.backgroundBaseInteractiveHoverAssistance` - `euiTheme.colors.borderStrongAssistance` - `euiTheme.colors.borderBaseAssistance` - `euiTheme.colors.textAssistance` - `euiTheme.colors.vis.euiColorVisAssistance` - `euiTheme.colors.severity.assistance` - `euiTheme.colors.vis.euiColorVis10` - `euiTheme.colors.vis.euiColorVis11` - `euiTheme.colors.vis.euiColorVisText10` - `euiTheme.colors.vis.euiColorVisText11` - Updated purple color palette shades 30-60 to slightly lighter values ([elastic#9383](elastic/eui#9383))
Summary
purple30,purple40,purple50,purple60(see Figma).Tokens updated
purple30#DECDFE#E2D3FEpurple40#CEB6FC#D1BAFCpurple50#BF9CF9#C5A5FApurple60#B084F5#B386F9Tokens added
colors.backgroundFilledAssistancecolors.backgroundLightAssistancecolors.backgroundBaseAssistancecomponents.buttons.backgroundAssistanceHovercomponents.buttons.backgroundFilledAssistanceHovercolors.backgroundBaseInteractiveHoverAssistancecolors.borderStrongAssistancecolors.borderBaseAssistancecolors.textAssistancecolors.vis.euiColorVisAssistance,colors.severity.assistancecolors.vis.euiColorVis10colors.vis.euiColorVis11colors.vis.euiColorVisText10colors.vis.euiColorVisText11Why are we making this change?
Resolves #9319
There are 2 consumer needs for the purple palette:
To get the in-between values of the purple palette, we can use the EUI custom color palettes utility, e.g
const downsamplingPalette = colorPalette([euiTheme.colors.backgroundLightAssistance, euiTheme.colors.backgroundFilledAssistance], 10):Screenshots #
Impact to users
🟢
QA
Specific checklist (WIP)
const downsamplingPalette = colorPalette([euiTheme.colors.backgroundLightAssistance, euiTheme.colors.backgroundFilledAssistance], 10)General checklist
@defaultif default values are missing) and playground toggles