[Docs] Show a gray favicon in dev mode#9794
Open
MannXo wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
This is a documentation-only change to |
|
👋 Since this is a community submitted pull request, a Buildkite build has not been started automatically. Would an Elastic organization member please verify the contents of this pull request and kick off a build manually? |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
💚 Build Succeeded
|
💚 Build Succeeded
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #9732
packages/website/docusaurus.config.tshardcodedfavicon: 'favicon.ico', so the local dev site shows the same colored favicon as production. With the dev server andeui.elastic.coopen in adjacent tabs, it's easy to lose track of which one you're looking at.This adds a
favicon-dev.svg, a desaturated version of the existing EUI mark (static/images/eui_logo.svg) using an SVGfeColorMatrixgrayscale filter on the original colored paths rather than a single flat gray fill — this preserves the relative luminance/contrast between the four shapes, so the mark stays recognizable at favicon size instead of reading as a flat blob.docusaurus.config.tsnow picksfavicon-dev.svgwhenNODE_ENV === 'development'(reusing the same env check already used one line above forstorybookBaseUrl), falling back to the existingfavicon.icootherwise.Note: the reference screenshot originally attached to this issue (
user-attachments/assets/47241641-...) is dead (404, confirmed authenticated) — this was independently verified against source and by comparing a flat-gray vs. grayscale-filter render side by side.API Changes
N/A — docs site theme change only, no
@elastic/euipublic API affected.Screenshots
Functionally verified:
yarn build(prod) resolves<link rel="icon" href="/favicon.ico">;yarn start(dev) resolves<link rel="icon" href="/favicon-dev.svg">.Impact Assessment
🔴 Breaking changes🧪 Test impact🔧 Hard to integrateImpact level: 🟢 None — local dev-only, no consumer-facing or production change.
Release Readiness
DocumentationFigmaMigration guideAdoption planQA instructions for reviewer
yarn start) and confirm the browser tab shows the gray faviconyarn build) still resolves the coloredfavicon.icoChecklist before marking Ready for Review
QA: Tested light/dark modes, high contrast, mobile, Chrome/Safari/Edge/Firefox, keyboard-only, screen readerQA: Tested in CodeSandbox and KibanaTests: Added/updated Jest, Cypress, and VRTChangelog: Added changelog entry(docs-only change per changelogs.md — requestingskip-changeloglabel in a comment, no permission to self-apply)Breaking changesReviewer checklist