Skip to content

[Icon] New tableSparkles icon - #9987

Open
JoseLuisGJ wants to merge 6 commits into
elastic:mainfrom
JoseLuisGJ:icon-tableSparkles
Open

[Icon] New tableSparkles icon#9987
JoseLuisGJ wants to merge 6 commits into
elastic:mainfrom
JoseLuisGJ:icon-tableSparkles

Conversation

@JoseLuisGJ

@JoseLuisGJ JoseLuisGJ commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Summary

  • What: Added a new tableSparkles icon.
  • Why: Related to the index context icon request in this issue [Icon] Context index #9927
  • Additional note: also skipping mobile variant for the Icon stories not needed in order to improve the CI

API Changes

component / parent prop / child change description
<EuiIcon/> iconType added value tableSparkles New icon

Screenshots

Light mode Dark mode
CleanShot 2026-09-02 at 11 56 25@2x CleanShot 2026-09-02 at 11 56 55@2x

Impact Assessment

Note: Most PRs should be tested in Kibana to help gauge their Impact before merging.

  • 🔴 Breaking changes — What will break? How many usages in Kibana/Cloud UI are impacted?
  • 💅 Visual changes — May impact style overrides; could require visual testing. Explain and estimate impact.
  • 🧪 Test impact — May break functional or snapshot tests (e.g., HTML structure, class names, default values).
  • 🔧 Hard to integrate — If changes require substantial updates to Kibana, please stage the changes and link them here.

Impact level: 🟢 None / 🟢 Low / 🟡 Moderate / 🔴 High

Release Readiness

  • Documentation: {link to docs page(s)}
  • Figma: New tableSparkles component already added into the Figma library here
  • Migration guide: {steps or link, for breaking/visual changes or deprecations}
  • Adoption plan (new features): {link to issue/doc or outline who will integrate this and where}

QA instructions for reviewer

Checklist before marking Ready for Review

Reviewer checklist

  • Approved Impact Assessment — Acceptable to merge given the consumer impact.
  • Approved Release Readiness — Docs, Figma, and migration info are sufficient to ship.

@JoseLuisGJ
JoseLuisGJ marked this pull request as ready for review September 2, 2026 10:22
@JoseLuisGJ
JoseLuisGJ requested a review from a team as a code owner September 2, 2026 10:22
Copilot AI lite review requested due to automatic review settings September 2, 2026 10:22
@JoseLuisGJ JoseLuisGJ linked an issue Sep 2, 2026 that may be closed by this pull request
@JoseLuisGJ JoseLuisGJ self-assigned this Sep 2, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

There’s at least one concrete fix needed ('AI' synonym casing) and the PR also includes unrelated i18n token churn that should be confirmed intentional or split out.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Adds a new tableSparkles icon to EUI’s icon system (raw SVG + generated React asset) and registers it in the icon map so it can be used via <EuiIcon iconType="tableSparkles" />.

Changes:

  • Added table_sparkles.svg and the generated assets/table_sparkles.tsx component.
  • Registered tableSparkles in icon_map.ts with search metadata synonyms.
  • Updated icon snapshots and added an upcoming changelog entry (plus additional i18n token file churn).
File summaries
File Description
packages/eui/src/components/icon/svgs/table_sparkles.svg Adds the new raw SVG source for the icon.
packages/eui/src/components/icon/assets/table_sparkles.tsx Adds the generated React icon component exported as icon.
packages/eui/src/components/icon/icon_map.ts Registers tableSparkles and associates metadata/synonyms for search.
packages/eui/src/components/icon/snapshots/icon.test.tsx.snap Updates Jest snapshots to include the new icon render output.
packages/eui/i18ntokens.json Large i18n token file reordering/regeneration included in the PR.
packages/eui/i18ntokens_changelog.json Adds a new i18n token changelog entry (version 120.0.0).
packages/eui/changelogs/upcoming/9987.md Adds an upcoming changelog note for the new icon.
Review details
  • Files reviewed: 5/7 changed files
  • Comments generated: 3
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread packages/eui/i18ntokens.json
Comment thread packages/eui/i18ntokens_changelog.json Outdated
Comment thread packages/eui/src/components/icon/icon_map.ts Outdated
JoseLuisGJ and others added 2 commits September 2, 2026 12:28
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown

📷 2 visual difference(s) found

Look at the visual diff below. If everything is expected, run Approve visual changes to update baselines, re-run the job or make appropriate fixes.

See the visual regression testing wiki for more information.

Expand to review

euiicon (2 differences)

StoryDiff %BeforeAfterDiff
all icons desktop 8.24%
all icons mobile n/a

@weronikaolejniczak weronikaolejniczak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! While you're here, @JoseLuisGJ, could you skip the mobile variant of the Icons story? We don't need it and it just slows down the CI. I ask because we need to update the snapshots.

Comment on lines +35 to +37
parameters: {
vrt: { skip: ['mobile'] },
},

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added this part to skip mobile variant @weronikaolejniczak

@infra-vault-gh-plugin-prod

Copy link
Copy Markdown

💚 Build Succeeded

History

cc @JoseLuisGJ

@infra-vault-gh-plugin-prod

infra-vault-gh-plugin-prod Bot commented Sep 2, 2026

Copy link
Copy Markdown

💔 Build Failed

Failed CI Steps

History

cc @JoseLuisGJ

@elastic-vault-github-plugin-prod

Copy link
Copy Markdown

📷 1 visual difference(s) found

Look at the visual diff below. If everything is expected, run Approve visual changes to update baselines, re-run the job or make appropriate fixes.

See the visual regression testing wiki for more information.

Expand to review

euiicon (1 difference)

StoryDiff %BeforeAfterDiff
all icons desktop 8.24%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Icon] Context index

3 participants