Skip to content

[OpAMP] enable OpAMP endpoint by default#6657

Merged
ycombinator merged 8 commits intoelastic:mainfrom
ycombinator:opamp-ff-default-enabled
Mar 25, 2026
Merged

[OpAMP] enable OpAMP endpoint by default#6657
ycombinator merged 8 commits intoelastic:mainfrom
ycombinator:opamp-ff-default-enabled

Conversation

@ycombinator
Copy link
Copy Markdown
Contributor

@ycombinator ycombinator commented Mar 24, 2026

Summary

Previously, the OpAMP endpoint was disabled by default. Users had to explicitly enable it by adding the following to their Fleet Server configuration:

server:
  feature_flags:
    enable_opamp: true

With this change, the OpAMP endpoint is enabled by default. Users who need to disable it can do so by setting server.feature_flags.enable_opamp: false in the Fleet Server input's configuration.

Changes in this PR

  • Set EnableOpAMP to true in InitDefaults() so the OpAMP endpoint is enabled out of the box
  • Update config tests to use defaultServer() with overrides instead of manually built structs, removing unused test helpers
  • Update reference config, setup docs, and e2e test template to reflect the new default

🤖 Generated with Claude Code

ycombinator and others added 6 commits March 24, 2026 14:30
Set EnableOpAMP to true in InitDefaults() so the OpAMP endpoint
is enabled out of the box without requiring explicit configuration.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace the manually built Server struct with defaultServer() plus
overrides so it picks up the new EnableOpAMP default. Remove unused
helpers (defaultServerBulk, defaultServerGC, defaultPBKDF2).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Rename test cases to "explicitly disabled/enabled" to reflect that
the flag now defaults to true.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The feature flag is now enabled by default, so the docs now explain
how to disable it rather than how to enable it.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The flag now defaults to true, so explicitly setting it is unnecessary.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 24, 2026

This pull request does not have a backport label. Could you fix it @ycombinator? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label to automatically backport to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@ycombinator ycombinator changed the title feat: enable OpAMP feature flag by default [OpAMP] enable OpAMP endpoint by default Mar 24, 2026
@ycombinator ycombinator added Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team backport-active-9 Automated backport with mergify to all the active 9.[0-9]+ branches labels Mar 24, 2026
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@ycombinator ycombinator requested a review from a team as a code owner March 24, 2026 21:47
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copy link
Copy Markdown
Member

@ebeahan ebeahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ycombinator ycombinator merged commit fee63f0 into elastic:main Mar 25, 2026
11 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

@Mergifyio backport 9.2 9.3

@ycombinator ycombinator deleted the opamp-ff-default-enabled branch March 25, 2026 16:30
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 25, 2026

backport 9.2 9.3

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request Mar 25, 2026
* feat: enable OpAMP feature flag by default

Set EnableOpAMP to true in InitDefaults() so the OpAMP endpoint
is enabled out of the box without requiring explicit configuration.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* test: update config test to use defaultServer() for input-config case

Replace the manually built Server struct with defaultServer() plus
overrides so it picks up the new EnableOpAMP default. Remove unused
helpers (defaultServerBulk, defaultServerGC, defaultPBKDF2).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* test: clarify feature flag test case names

Rename test cases to "explicitly disabled/enabled" to reflect that
the flag now defaults to true.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* docs: update reference config to reflect OpAMP enabled by default

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* docs: update OpAMP setup guide for default-enabled flag

The feature flag is now enabled by default, so the docs now explain
how to disable it rather than how to enable it.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* e2e: remove redundant enable_opamp flag from OpAMP test template

The flag now defaults to true, so explicitly setting it is unnecessary.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* changelog: add fragment for OpAMP feature flag default change

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* chore: fix gofmt formatting in config_test.go

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
(cherry picked from commit fee63f0)
mergify bot pushed a commit that referenced this pull request Mar 25, 2026
* feat: enable OpAMP feature flag by default

Set EnableOpAMP to true in InitDefaults() so the OpAMP endpoint
is enabled out of the box without requiring explicit configuration.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* test: update config test to use defaultServer() for input-config case

Replace the manually built Server struct with defaultServer() plus
overrides so it picks up the new EnableOpAMP default. Remove unused
helpers (defaultServerBulk, defaultServerGC, defaultPBKDF2).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* test: clarify feature flag test case names

Rename test cases to "explicitly disabled/enabled" to reflect that
the flag now defaults to true.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* docs: update reference config to reflect OpAMP enabled by default

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* docs: update OpAMP setup guide for default-enabled flag

The feature flag is now enabled by default, so the docs now explain
how to disable it rather than how to enable it.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* e2e: remove redundant enable_opamp flag from OpAMP test template

The flag now defaults to true, so explicitly setting it is unnecessary.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* changelog: add fragment for OpAMP feature flag default change

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* chore: fix gofmt formatting in config_test.go

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
(cherry picked from commit fee63f0)
ycombinator added a commit that referenced this pull request Mar 25, 2026
* feat: enable OpAMP feature flag by default

Set EnableOpAMP to true in InitDefaults() so the OpAMP endpoint
is enabled out of the box without requiring explicit configuration.



* test: update config test to use defaultServer() for input-config case

Replace the manually built Server struct with defaultServer() plus
overrides so it picks up the new EnableOpAMP default. Remove unused
helpers (defaultServerBulk, defaultServerGC, defaultPBKDF2).



* test: clarify feature flag test case names

Rename test cases to "explicitly disabled/enabled" to reflect that
the flag now defaults to true.



* docs: update reference config to reflect OpAMP enabled by default



* docs: update OpAMP setup guide for default-enabled flag

The feature flag is now enabled by default, so the docs now explain
how to disable it rather than how to enable it.



* e2e: remove redundant enable_opamp flag from OpAMP test template

The flag now defaults to true, so explicitly setting it is unnecessary.



* changelog: add fragment for OpAMP feature flag default change



* chore: fix gofmt formatting in config_test.go



---------


(cherry picked from commit fee63f0)

Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
ycombinator added a commit that referenced this pull request Mar 25, 2026
* feat: enable OpAMP feature flag by default

Set EnableOpAMP to true in InitDefaults() so the OpAMP endpoint
is enabled out of the box without requiring explicit configuration.



* test: update config test to use defaultServer() for input-config case

Replace the manually built Server struct with defaultServer() plus
overrides so it picks up the new EnableOpAMP default. Remove unused
helpers (defaultServerBulk, defaultServerGC, defaultPBKDF2).



* test: clarify feature flag test case names

Rename test cases to "explicitly disabled/enabled" to reflect that
the flag now defaults to true.



* docs: update reference config to reflect OpAMP enabled by default



* docs: update OpAMP setup guide for default-enabled flag

The feature flag is now enabled by default, so the docs now explain
how to disable it rather than how to enable it.



* e2e: remove redundant enable_opamp flag from OpAMP test template

The flag now defaults to true, so explicitly setting it is unnecessary.



* changelog: add fragment for OpAMP feature flag default change



* chore: fix gofmt formatting in config_test.go



---------


(cherry picked from commit fee63f0)

Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-active-9 Automated backport with mergify to all the active 9.[0-9]+ branches Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants