[OpAMP] enable OpAMP endpoint by default#6657
Merged
ycombinator merged 8 commits intoelastic:mainfrom Mar 25, 2026
Merged
Conversation
Set EnableOpAMP to true in InitDefaults() so the OpAMP endpoint is enabled out of the box without requiring explicit configuration. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace the manually built Server struct with defaultServer() plus overrides so it picks up the new EnableOpAMP default. Remove unused helpers (defaultServerBulk, defaultServerGC, defaultPBKDF2). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Rename test cases to "explicitly disabled/enabled" to reflect that the flag now defaults to true. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The feature flag is now enabled by default, so the docs now explain how to disable it rather than how to enable it. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The flag now defaults to true, so explicitly setting it is unnecessary. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
This pull request does not have a backport label. Could you fix it @ycombinator? 🙏
|
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ebeahan
reviewed
Mar 25, 2026
michel-laterman
approved these changes
Mar 25, 2026
Contributor
|
@Mergifyio backport 9.2 9.3 |
Contributor
✅ Backports have been createdDetails
|
mergify bot
pushed a commit
that referenced
this pull request
Mar 25, 2026
* feat: enable OpAMP feature flag by default Set EnableOpAMP to true in InitDefaults() so the OpAMP endpoint is enabled out of the box without requiring explicit configuration. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * test: update config test to use defaultServer() for input-config case Replace the manually built Server struct with defaultServer() plus overrides so it picks up the new EnableOpAMP default. Remove unused helpers (defaultServerBulk, defaultServerGC, defaultPBKDF2). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * test: clarify feature flag test case names Rename test cases to "explicitly disabled/enabled" to reflect that the flag now defaults to true. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * docs: update reference config to reflect OpAMP enabled by default Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * docs: update OpAMP setup guide for default-enabled flag The feature flag is now enabled by default, so the docs now explain how to disable it rather than how to enable it. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * e2e: remove redundant enable_opamp flag from OpAMP test template The flag now defaults to true, so explicitly setting it is unnecessary. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * changelog: add fragment for OpAMP feature flag default change Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * chore: fix gofmt formatting in config_test.go Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> (cherry picked from commit fee63f0)
mergify bot
pushed a commit
that referenced
this pull request
Mar 25, 2026
* feat: enable OpAMP feature flag by default Set EnableOpAMP to true in InitDefaults() so the OpAMP endpoint is enabled out of the box without requiring explicit configuration. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * test: update config test to use defaultServer() for input-config case Replace the manually built Server struct with defaultServer() plus overrides so it picks up the new EnableOpAMP default. Remove unused helpers (defaultServerBulk, defaultServerGC, defaultPBKDF2). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * test: clarify feature flag test case names Rename test cases to "explicitly disabled/enabled" to reflect that the flag now defaults to true. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * docs: update reference config to reflect OpAMP enabled by default Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * docs: update OpAMP setup guide for default-enabled flag The feature flag is now enabled by default, so the docs now explain how to disable it rather than how to enable it. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * e2e: remove redundant enable_opamp flag from OpAMP test template The flag now defaults to true, so explicitly setting it is unnecessary. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * changelog: add fragment for OpAMP feature flag default change Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * chore: fix gofmt formatting in config_test.go Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> (cherry picked from commit fee63f0)
ycombinator
added a commit
that referenced
this pull request
Mar 25, 2026
* feat: enable OpAMP feature flag by default Set EnableOpAMP to true in InitDefaults() so the OpAMP endpoint is enabled out of the box without requiring explicit configuration. * test: update config test to use defaultServer() for input-config case Replace the manually built Server struct with defaultServer() plus overrides so it picks up the new EnableOpAMP default. Remove unused helpers (defaultServerBulk, defaultServerGC, defaultPBKDF2). * test: clarify feature flag test case names Rename test cases to "explicitly disabled/enabled" to reflect that the flag now defaults to true. * docs: update reference config to reflect OpAMP enabled by default * docs: update OpAMP setup guide for default-enabled flag The feature flag is now enabled by default, so the docs now explain how to disable it rather than how to enable it. * e2e: remove redundant enable_opamp flag from OpAMP test template The flag now defaults to true, so explicitly setting it is unnecessary. * changelog: add fragment for OpAMP feature flag default change * chore: fix gofmt formatting in config_test.go --------- (cherry picked from commit fee63f0) Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
ycombinator
added a commit
that referenced
this pull request
Mar 25, 2026
* feat: enable OpAMP feature flag by default Set EnableOpAMP to true in InitDefaults() so the OpAMP endpoint is enabled out of the box without requiring explicit configuration. * test: update config test to use defaultServer() for input-config case Replace the manually built Server struct with defaultServer() plus overrides so it picks up the new EnableOpAMP default. Remove unused helpers (defaultServerBulk, defaultServerGC, defaultPBKDF2). * test: clarify feature flag test case names Rename test cases to "explicitly disabled/enabled" to reflect that the flag now defaults to true. * docs: update reference config to reflect OpAMP enabled by default * docs: update OpAMP setup guide for default-enabled flag The feature flag is now enabled by default, so the docs now explain how to disable it rather than how to enable it. * e2e: remove redundant enable_opamp flag from OpAMP test template The flag now defaults to true, so explicitly setting it is unnecessary. * changelog: add fragment for OpAMP feature flag default change * chore: fix gofmt formatting in config_test.go --------- (cherry picked from commit fee63f0) Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previously, the OpAMP endpoint was disabled by default. Users had to explicitly enable it by adding the following to their Fleet Server configuration:
With this change, the OpAMP endpoint is enabled by default. Users who need to disable it can do so by setting
server.feature_flags.enable_opamp: falsein the Fleet Server input's configuration.Changes in this PR
EnableOpAMPtotrueinInitDefaults()so the OpAMP endpoint is enabled out of the boxdefaultServer()with overrides instead of manually built structs, removing unused test helpers🤖 Generated with Claude Code