[9.3](backport #6835) fix: correct typos in default rate limit YAML keys#6846
Merged
michel-laterman merged 1 commit into9.3from Apr 16, 2026
Merged
[9.3](backport #6835) fix: correct typos in default rate limit YAML keys#6846michel-laterman merged 1 commit into9.3from
michel-laterman merged 1 commit into9.3from
Conversation
* fix: correct typos in default rate limit YAML keys The embedded default YAML files used `pgp_retieval_limit` (missing 'r') instead of `pgp_retrieval_limit`, causing the values to never deserialize into the Go struct. PGP retrieval limits silently fell back to hardcoded defaults for all agent-count tiers. Also fixes `policy_interval` -> `policy_limit` in lte10000_limits.yml and renames `lte2500_limite.yml` -> `lte2500_limits.yml`. Adds a regression test that verifies all embedded YAML files populate every limit field, catching future key/struct-tag mismatches. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * test: use reflection to validate YAML keys match struct tags Replace manually enumerated field assertions with a reflection-based approach that reads raw YAML keys and verifies each has a matching `config` struct tag on serverLimitDefaults. This catches typos automatically without needing to update the test when fields are added. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Cleanup test code * Update internal/pkg/config/env_defaults_test.go Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com> (cherry picked from commit 47b6210)
5 tasks
github-actions
bot
added
bug
michel-laterman
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the problem this PR solves?
All 6 embedded default YAML files under
internal/pkg/config/defaults/usedpgp_retieval_limit(missing 'r') instead ofpgp_retrieval_limit. Because the Go struct tag isconfig:"pgp_retrieval_limit", the YAML values never deserialized — PGP retrieval rate limits silently fell back to hardcoded defaults regardless of agent-count tier.Additionally,
lte10000_limits.ymlusedpolicy_intervalinstead ofpolicy_limit, causing the same silent fallback for the policy rate limit at the 5001-10000 agent tier.How does this PR solve the problem?
pgp_retieval_limit→pgp_retrieval_limitin all 6 default YAML filespolicy_interval→policy_limitinlte10000_limits.ymllte2500_limite.yml→lte2500_limits.ymlfor consistencyTestDefaultLimitsYAMLKeysregression test that verifies all embedded YAML files populate every limit field with non-zero values, catching future key/struct-tag mismatchesHow to test this PR locally
Design Checklist
Checklist
./changelog/fragmentsusing the changelog toolThis is an automatic backport of pull request fix: correct typos in default rate limit YAML keys #6835 done by Mergify.