[8.19](backport #7007) Fix missing authAgent in UploadChunk#7020
Merged
Conversation
In the UploadChunk the authAgent was not being called to validate that the uploading agent of the chunk has the permissions to write that chunk. It validated that there was a valid API key, it just didn't validate that the agent with the valid API key is the agent that should be uploading the chunk. (cherry picked from commit 4425e63)
5 tasks
swiatekm
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the problem this PR solves?
In the
UploadChunktheauthAgentwas not being called to validate that the uploading agent of the chunk has the permissions to write that chunk. It validated that there was a valid API key, it just didn't validate that the agent with the valid API key is the agent that should be uploading the chunk.In
ValidAPIKeya disabled API key was considered valid even once disabled.How does this PR solve the problem?
It adds the
authAgentcheck to theUploadChunk.It sets
ok = falsewhen the API key is disabled inCacheT.ValidAPIKey.Design Checklist
[ ] I have included fail safe mechanisms to limit the load on fleet-server: rate limiting, circuit breakers, caching, load shedding, etc.Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files./changelog/fragmentsusing the changelog toolThis is an automatic backport of pull request #7007 done by [Mergify](https://mergify.com).