Skip to content

Ignore the ELASTICSEARCH_URL variable when address is passed in configuration #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 10, 2019
Merged

Ignore the ELASTICSEARCH_URL variable when address is passed in configuration #115

merged 1 commit into from
Dec 10, 2019

Conversation

@karmi
Copy link
Contributor

@karmi karmi commented Dec 8, 2019

To prevent issues reported in #113, when the addresses are set in configuration — either via cfg.Addresses or cfg.CloudID —, ignore the ELASTICSEARCH_URL variable.

@karmi karmi requested a review from graphaelli December 8, 2019 14:09
karmi added a commit that referenced this pull request Dec 10, 2019
@karmi
Ignore the ELASTICSEARCH_URL variable when address is passed in confi…
14742ae 
…guration

Fixes #113
Closes #115
@karmi karmi merged commit 86a626c into master Dec 10, 2019
karmi added a commit that referenced this pull request Dec 10, 2019
@karmi
Ignore the ELASTICSEARCH_URL variable when address is passed in confi…
f0c66f5 
…guration

Fixes #113
Closes #115

(cherry picked from commit 86a626c)
karmi added a commit that referenced this pull request Dec 10, 2019
@karmi
Ignore the ELASTICSEARCH_URL variable when address is passed in confi…
ed288cd 
…guration

Fixes #113
Closes #115

(cherry picked from commit 86a626c)
@karmi karmi deleted the fix_env_cfg branch December 10, 2019 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@graphaelli graphaelli graphaelli approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@karmi @graphaelli