Product check fixes #303
Merged
Product check fixes #303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- don't issue original request if product check fails - check original request error before response header check (avoiding panic)
The product check could have failed because of a transient network error, so repeat the check on subsequent requests as long as there has not been a prior success.
Contributor
|
LGTM! |
Anaethelion
pushed a commit
to Anaethelion/go-elasticsearch
that referenced
this pull request
Jul 12, 2021
* Product check improvements - don't issue original request if product check fails - check original request error before response header check (avoiding panic) * Don't cache product check errors The product check could have failed because of a transient network error, so repeat the check on subsequent requests as long as there has not been a prior success.
Anaethelion
added a commit
that referenced
this pull request
Jul 12, 2021
* Product check improvements - don't issue original request if product check fails - check original request error before response header check (avoiding panic) * Don't cache product check errors The product check could have failed because of a transient network error, so repeat the check on subsequent requests as long as there has not been a prior success. Co-authored-by: Andrew Wilkins <axw@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sync.Onceapproach so transient network errors are not cached