[hackerone] Initial release of HackerOne with Report data streams#18951
[hackerone] Initial release of HackerOne with Report data streams#18951clement-fouque wants to merge 6 commits into
Conversation
Vale Linting ResultsSummary: 9 warnings, 35 suggestions found
|
| File | Line | Rule | Message |
|---|---|---|---|
| packages/hackerone/docs/README.md | 116 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'. |
| packages/hackerone/docs/README.md | 116 | Elastic.DontUse | Don't use 'please'. |
| packages/hackerone/docs/README.md | 359 | Elastic.DontUse | Don't use 'just'. |
| packages/hackerone/docs/README.md | 375 | Elastic.QuotesPunctuation | Place punctuation inside closing quotation marks. |
| packages/hackerone/docs/README.md | 375 | Elastic.QuotesPunctuation | Place punctuation inside closing quotation marks. |
| packages/hackerone/docs/README.md | 488 | Elastic.DontUse | Don't use 'Thus'. |
| packages/hackerone/docs/README.md | 510 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'. |
| packages/hackerone/docs/README.md | 510 | Elastic.DontUse | Don't use 'please'. |
| packages/hackerone/docs/README.md | 754 | Elastic.DontUse | Don't use 'just'. |
💡 Suggestions (35)
| File | Line | Rule | Message |
|---|---|---|---|
| packages/hackerone/_dev/build/docs/README.md | 87 | Elastic.WordChoice | Consider using 'can, might' instead of 'may', unless the term is in the UI. |
| packages/hackerone/_dev/build/docs/README.md | 93 | Elastic.Semicolons | Use semicolons judiciously. |
| packages/hackerone/docs/README.md | 88 | Elastic.WordChoice | Consider using 'can, might' instead of 'may', unless the term is in the UI. |
| packages/hackerone/docs/README.md | 94 | Elastic.Semicolons | Use semicolons judiciously. |
| packages/hackerone/docs/README.md | 106 | Elastic.WordChoice | Consider using 'can, might' instead of 'may', unless the term is in the UI. |
| packages/hackerone/docs/README.md | 114 | Elastic.Wordiness | Consider using 'tell' instead of 'inform'. |
| packages/hackerone/docs/README.md | 114 | Elastic.WordChoice | Consider using 'can, might' instead of 'may', unless the term is in the UI. |
| packages/hackerone/docs/README.md | 114 | Elastic.WordChoice | Consider using 'can, might' instead of 'may', unless the term is in the UI. |
| packages/hackerone/docs/README.md | 116 | Elastic.WordChoice | Consider using 'can, might' instead of 'may', unless the term is in the UI. |
| packages/hackerone/docs/README.md | 116 | Elastic.WordChoice | Consider using 'deactivated, deselected, hidden, turned off, unavailable' instead of 'disabled', unless the term is in the UI. |
| packages/hackerone/docs/README.md | 117 | Elastic.WordChoice | Consider using 'efficiently' instead of 'simply', unless the term is in the UI. |
| packages/hackerone/docs/README.md | 117 | Elastic.WordChoice | Consider using 'can, might' instead of 'may', unless the term is in the UI. |
| packages/hackerone/docs/README.md | 124 | Elastic.Clone | Use cloning only when referring to cloning a GitHub repository or creating a copy that is linked to the original. Often confused with 'copy' and 'duplicate'. |
| packages/hackerone/docs/README.md | 227 | Elastic.WordChoice | Consider using 'deactivated, deselected, hidden, turned off, unavailable' instead of 'disabled', unless the term is in the UI. |
| packages/hackerone/docs/README.md | 242 | Elastic.WordChoice | Consider using 'deactivated, deselected, hidden, turned off, unavailable' instead of 'disabled', unless the term is in the UI. |
| packages/hackerone/docs/README.md | 259 | Elastic.WordChoice | Consider using 'deactivated, deselected, hidden, turned off, unavailable' instead of 'disabled', unless the term is in the UI. |
| packages/hackerone/docs/README.md | 326 | Elastic.WordChoice | Consider using 'deactivated, deselected, hidden, turned off, unavailable' instead of 'disabled', unless the term is in the UI. |
| packages/hackerone/docs/README.md | 336 | Elastic.WordChoice | Consider using 'deactivated, deselected, hidden, turned off, unavailable' instead of 'disabled', unless the term is in the UI. |
| packages/hackerone/docs/README.md | 359 | Elastic.WordChoice | Consider using 'can, might' instead of 'may', unless the term is in the UI. |
| packages/hackerone/docs/README.md | 500 | Elastic.WordChoice | Consider using 'can, might' instead of 'may', unless the term is in the UI. |
| packages/hackerone/docs/README.md | 508 | Elastic.Wordiness | Consider using 'tell' instead of 'inform'. |
| packages/hackerone/docs/README.md | 508 | Elastic.WordChoice | Consider using 'can, might' instead of 'may', unless the term is in the UI. |
| packages/hackerone/docs/README.md | 508 | Elastic.WordChoice | Consider using 'can, might' instead of 'may', unless the term is in the UI. |
| packages/hackerone/docs/README.md | 510 | Elastic.WordChoice | Consider using 'can, might' instead of 'may', unless the term is in the UI. |
| packages/hackerone/docs/README.md | 510 | Elastic.WordChoice | Consider using 'deactivated, deselected, hidden, turned off, unavailable' instead of 'disabled', unless the term is in the UI. |
| packages/hackerone/docs/README.md | 511 | Elastic.WordChoice | Consider using 'efficiently' instead of 'simply', unless the term is in the UI. |
| packages/hackerone/docs/README.md | 511 | Elastic.WordChoice | Consider using 'can, might' instead of 'may', unless the term is in the UI. |
| packages/hackerone/docs/README.md | 518 | Elastic.Clone | Use cloning only when referring to cloning a GitHub repository or creating a copy that is linked to the original. Often confused with 'copy' and 'duplicate'. |
| packages/hackerone/docs/README.md | 621 | Elastic.WordChoice | Consider using 'deactivated, deselected, hidden, turned off, unavailable' instead of 'disabled', unless the term is in the UI. |
| packages/hackerone/docs/README.md | 636 | Elastic.WordChoice | Consider using 'deactivated, deselected, hidden, turned off, unavailable' instead of 'disabled', unless the term is in the UI. |
| packages/hackerone/docs/README.md | 653 | Elastic.WordChoice | Consider using 'deactivated, deselected, hidden, turned off, unavailable' instead of 'disabled', unless the term is in the UI. |
| packages/hackerone/docs/README.md | 720 | Elastic.WordChoice | Consider using 'deactivated, deselected, hidden, turned off, unavailable' instead of 'disabled', unless the term is in the UI. |
| packages/hackerone/docs/README.md | 730 | Elastic.WordChoice | Consider using 'deactivated, deselected, hidden, turned off, unavailable' instead of 'disabled', unless the term is in the UI. |
| packages/hackerone/docs/README.md | 754 | Elastic.WordChoice | Consider using 'can, might' instead of 'may', unless the term is in the UI. |
| packages/hackerone/docs/README.md | 793 | Elastic.WordChoice | Consider using 'can, might' instead of 'may', unless the term is in the UI. |
The Vale linter checks documentation changes against the Elastic Docs style guide.
To use Vale locally or report issues, refer to Elastic style guide for Vale.
|
@efd6 can you perform a review of the CEL part? Thanks. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| resp.Body.decode_json().as(body, | ||
| { | ||
| // Resolve relative `links.next` against state.url; absolute URLs pass through. | ||
| "nextResolved": ((body.?links.?next.orValue(null) != null) ? string(body.links.next) : "").as(linkNext, |
There was a problem hiding this comment.
Does the API return null in this case?
There was a problem hiding this comment.
I believe so as response is:
{
[...],
"links": {}
}There was a problem hiding this comment.
That's not null, that's absence. null would look like this:
{
[...],
"links": {"next": null}
}
There was a problem hiding this comment.
If it does, we should not be using "" sentinels.
| "pageMax": body.?data.orValue([]).map(r, | ||
| r.attributes.?last_activity_at.orValue(r.attributes.?created_at.orValue("")) | ||
| ).filter(t, t != "").as(stamps, | ||
| (size(stamps) > 0) ? stamps.max() : "" | ||
| ), |
There was a problem hiding this comment.
Why are we using "" as a sentinel when there is nothing here?
But also,
| "pageMax": body.?data.orValue([]).map(r, | |
| r.attributes.?last_activity_at.orValue(r.attributes.?created_at.orValue("")) | |
| ).filter(t, t != "").as(stamps, | |
| (size(stamps) > 0) ? stamps.max() : "" | |
| ), | |
| "pageMax": body.?data.orValue([]).map(r, has(r.?attributes.last_activity_at) || has(r.?attributes.created_at), | |
| r.attributes.?last_activity_at.orValue(r.attributes.created_at) | |
| ).as(stamps, | |
| (size(stamps) > 0) ? stamps.max() : "" | |
| ), |
🚀 Benchmarks reportTo see the full report comment with |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
7ab7673 to
92037e3
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
d394b3e to
ce28db2
Compare
This comment has been minimized.
This comment has been minimized.
TL;DRBuildkite failed before tests ran because the PR commit could not be merged with Remediation
Investigation detailsRoot CauseThe failure happens in the repository post-checkout hook when Buildkite creates
This merge fails with unrelated histories, which indicates the PR commit lineage does not share ancestry with Evidence
Verification
Follow-upIf this branch was intentionally created from a disconnected history, open a fresh branch from upstream Note 🔒 Integrity filter blocked 2 itemsThe following items were blocked because they don't meet the GitHub integrity level.
To allow these resources, lower tools:
github:
min-integrity: approved # merged | approved | unapproved | noneWhat is this? | From workflow: PR Buildkite Detective Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. |
…ment-fouque/elastic-integrations into hackerone-new-integration-v5
…s for JSON acceptance
💚 Build Succeeded
History
|
Proposed commit message
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots