Skip to content

[cisco_ise]: Pipeline failed to set event.outcome and user.name - #20386

Merged
qcorporation merged 4 commits into
mainfrom
19929-cisco-ise
Jul 30, 2026
Merged

[cisco_ise]: Pipeline failed to set event.outcome and user.name#20386
qcorporation merged 4 commits into
mainfrom
19929-cisco-ise

Conversation

@qcorporation

Copy link
Copy Markdown
Contributor

Proposed commit message

Set event.outcome and user.name for Administrative and Operational Audit message codes 60080, 60081, and 60084.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Related issues

@github-actions

Copy link
Copy Markdown
Contributor

✅ Elastic Docs Style Checker (Vale)

No issues found on modified lines!


The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale.

@andrewkroh andrewkroh added Integration:cisco_ise Cisco ISE documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. labels Jul 28, 2026
@qcorporation qcorporation added the Team:Integration-Experience Security Integrations Integration Experience [elastic/integration-experience] label Jul 28, 2026
@qcorporation qcorporation self-assigned this Jul 28, 2026
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@qcorporation
qcorporation marked this pull request as ready for review July 28, 2026 20:24
@qcorporation
qcorporation requested a review from a team as a code owner July 28, 2026 20:24
@infra-vault-gh-plugin-prod

Copy link
Copy Markdown

Pinging @elastic/integration-experience (Team:Integration-Experience)

Comment thread packages/cisco_ise/changelog.yml Outdated
Comment thread packages/cisco_ise/changelog.yml Outdated
@vera-review-bot

Copy link
Copy Markdown

Review summary

Issues found across the latest commits 7647daf — 4 medium, 2 low
  • 🟡 The changelog says event.outcome is set for codes 60080, 60081 and 60084, but the pipeline change actually sets it for 14 codes (link) (Unresolved)
  • 🔵 The changelog link uses the /issues/ path with this PR's own number (20386) (link) (Unresolved)
  • 🟡 The 60084 failure branch is a negation of the success regex, so any message that simply lacks the word "successfully" is labelled a failure and a missing OperationMessageText throws in the condition (link) (Unresolved)
  • 🟡 For a non-existent account sshd logs "Failed password for invalid user bob from ...", and the first grok pattern captures user.name as "invalid user bob" (link) (Unresolved)
  • 🟡 The new grok already matches the SSH client IP with %{IP} but discards it, so 60080/60081 authentication events carry no source address (link) (Unresolved)
  • 🔵 The user.name copy runs at line 591, before UserName is renamed to user.name at line 644 and before default.yml splits email-shaped admin names, so AdminName can win over UserName and an email can land in user.name (link) (Unresolved)

A new commit triggers another review — at most once every 15 minutes. I skip the PR while it's approved or has merge conflicts.

🤖 AI-Generated Review | Vera Review Bot | 📚 Knowledge base: integration-skills

⚠️ Automated review — verify suggestions before applying.

@mjwolf mjwolf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be good to address some of these bot comments, otherwise this looks good to me

@mergify

mergify Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

✅ All changelog entries have the correct PR link.

@infra-vault-gh-plugin-prod

Copy link
Copy Markdown

💚 Build Succeeded

History

cc @qcorporation

@qcorporation
qcorporation merged commit ea18b74 into main Jul 30, 2026
10 checks passed
@qcorporation
qcorporation deleted the 19929-cisco-ise branch July 30, 2026 12:23
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

Package cisco_ise - 1.32.10 containing this change is available at https://epr.elastic.co/package/cisco_ise/1.32.10/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. Integration:cisco_ise Cisco ISE Team:Integration-Experience Security Integrations Integration Experience [elastic/integration-experience]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[cisco_ise]: Pipeline failed to set event.outcome and user.name

3 participants