Skip to content

[cisco_ise]: add null check for script_parse_av_pairs processor - #20976

Merged
taylor-swanson merged 2 commits into
elastic:mainfrom
taylor-swanson:fix/cisco_ise-errors
Sep 1, 2026
Merged

[cisco_ise]: add null check for script_parse_av_pairs processor#20976
taylor-swanson merged 2 commits into
elastic:mainfrom
taylor-swanson:fix/cisco_ise-errors

Conversation

@taylor-swanson

@taylor-swanson taylor-swanson commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Proposed commit message

  • Add additional null checks when checking if cisco-av-pair is null, since log_details may be null in some situations. One scenario where this may happen is if the kv processor that writes to cisco_ise.log.log_details fails due to a truncated key/value pair.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
    - [ ] I have verified that any added dashboard complies with Kibana's Dashboard good practices

How to test this PR locally

cd packages/cisco_ise
elastic-package test

- Add additional null checks when checking if cisco-av-pair is null,
since log_details may be null in some situations. One scenario where
this may happen is if the kv processor that writes to
cisco_ise.log.log_details fails.
@taylor-swanson taylor-swanson self-assigned this Aug 31, 2026
@taylor-swanson taylor-swanson added Integration:cisco_ise Cisco ISE bugfix Pull request that fixes a bug issue Team:Integration-Experience Security Integrations Integration Experience [elastic/integration-experience] labels Aug 31, 2026
@github-actions

Copy link
Copy Markdown
Contributor

✅ Elastic Docs Style Checker (Vale)

No issues found on modified lines!


The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale.

@taylor-swanson

Copy link
Copy Markdown
Contributor Author

/test

@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

✅ All changelog entries have the correct PR link.

@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@infra-vault-gh-plugin-prod

Copy link
Copy Markdown

💚 Build Succeeded

History

cc @taylor-swanson

@taylor-swanson
taylor-swanson marked this pull request as ready for review September 1, 2026 12:30
@taylor-swanson
taylor-swanson requested a review from a team as a code owner September 1, 2026 12:30
@infra-vault-gh-plugin-prod

Copy link
Copy Markdown

Pinging @elastic/integration-experience (Team:Integration-Experience)

@vera-review-bot

Copy link
Copy Markdown

@taylor-swanson - 💤 This PR was approved before I picked it up, so I will leave it — automatic reviews are skipped on approved PRs. If you would still like a review, request one with a @vera-review-bot review comment (members and owners only).

@taylor-swanson
taylor-swanson merged commit c9c3877 into elastic:main Sep 1, 2026
9 checks passed
@taylor-swanson
taylor-swanson deleted the fix/cisco_ise-errors branch September 1, 2026 19:58
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

Package cisco_ise - 1.32.14 containing this change is available at https://epr.elastic.co/package/cisco_ise/1.32.14/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:cisco_ise Cisco ISE Team:Integration-Experience Security Integrations Integration Experience [elastic/integration-experience]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants