[Agent Builder] Remove stray delimiter in attachment header#276018
Conversation
The FlexItem wrapping the title/subtitle in AttachmentHeader was given a borderLeft in elastic#265883, intended as a visual separator from the icon. In practice it renders as an orphaned vertical bar on every attachment chip (dashboards, workflows, skills) — no icon is passed by most callers, and even when one is present the extra line reads as noise. Remove it. Closes elastic/search-team#15112
💛 Build succeeded, but was flaky
Failed CI Steps
Test Failures
Metrics [docs]Async chunks
History
cc @Kiryous |
|
Starting backport for target branches: 9.4 |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Backport resolution attempt complete
These backports were prepared by an agent. Please review the generated PRs carefully before merging.
|
…276018) Closes elastic/search-team#15112 ## Summary Every attachment chip (dashboards, workflows, skills, etc.) in the Agent Builder chat renders a stray vertical delimiter on the left side of the title. The delimiter is a `borderLeft` on the `EuiFlexItem` that wraps the title/subtitle, added in elastic#265883 as a visual separator from the icon. Most attachment callers don't pass an icon, so the border stands alone as an orphan; even when an icon is present the extra line reads as noise. Removing it matches the design intent. ## Before / After Before (from the issue): <img width="600" src="https://github.com/user-attachments/assets/7b1792a3-d1e5-472c-a335-41cc6ca1b171" /> After (verified locally on a workflow attachment):  ## Verification - Booted Kibana locally, opened Agent Builder, created a workflow attachment in a conversation. - Inspected the header's inner `EuiFlexItem` inline style: now `min-width: 0px` only, no `border-left`. - Reverted temporarily to a bright red border to confirm the correct element was being modified, then restored the fix. - `node scripts/type_check --project x-pack/platform/plugins/shared/agent_builder/tsconfig.json` — clean. ## Checklist - [x] Follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing) (no user-facing text change) - [x] Unit/functional tests not affected (pure CSS removal, no snapshot tests reference these styles)
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
9 similar comments
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Closes https://github.com/elastic/search-team/issues/15112
Summary
Every attachment chip (dashboards, workflows, skills, etc.) in the Agent Builder chat renders a stray vertical delimiter on the left side of the title. The delimiter is a
borderLefton theEuiFlexItemthat wraps the title/subtitle, added in #265883 as a visual separator from the icon. Most attachment callers don't pass an icon, so the border stands alone as an orphan; even when an icon is present the extra line reads as noise. Removing it matches the design intent.Before / After
Before (from the issue):
After (verified locally on a workflow attachment):
Verification
EuiFlexIteminline style: nowmin-width: 0pxonly, noborder-left.node scripts/type_check --project x-pack/platform/plugins/shared/agent_builder/tsconfig.json— clean.Checklist