[9.0] Removed config hash computation from pipeline (backport #17336) #17419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💚 Build Succeeded
cc @andsel |
Contributor
Author
|
This pull request has not been merged yet. Could you please review and merge it @andsel? 🙏 |
5 similar comments
Contributor
Author
|
This pull request has not been merged yet. Could you please review and merge it @andsel? 🙏 |
Contributor
Author
|
This pull request has not been merged yet. Could you please review and merge it @andsel? 🙏 |
Contributor
Author
|
This pull request has not been merged yet. Could you please review and merge it @andsel? 🙏 |
Contributor
Author
|
This pull request has not been merged yet. Could you please review and merge it @andsel? 🙏 |
Contributor
Author
|
This pull request has not been merged yet. Could you please review and merge it @andsel? 🙏 |
kaisecheng
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
[rn:skip]
What does this PR do?
Removed unused configHash computation happening in AbstractPipeline and used only in tests replaced by PipelineConfig.configHash() invocation
Why is it important/What is the impact to the user?
No user facing changes
Checklist
[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files (and/or docker env variables)[ ] I have added tests that prove my fix is effective or that my feature worksAuthor's Checklist
How to test this PR locally
Related issues
This is an automatic backport of pull request #17336 done by [Mergify](https://mergify.com).