Skip to content

bump lock file for 8.19 - #19378

Merged
donoghuc merged 1 commit into
8.19from
update_lock_8.19_1785847204
Aug 4, 2026
Merged

bump lock file for 8.19#19378
donoghuc merged 1 commit into
8.19from
update_lock_8.19_1785847204

Conversation

@github-actions

@github-actions github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@infra-vault-gh-plugin-prod

Copy link
Copy Markdown

💛 Build succeeded, but was flaky

Failed CI Steps

logstash-core-plugin-api (>= 1.60, <= 2.99)
logstash-mixin-ecs_compatibility_support (~> 1.1)
logstash-filter-csv (3.1.1)
logstash-filter-csv (3.1.2)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! 9.4 resolved csv to 3.3.5 before the bump

New version of csv-filter requires csv < 3.2.6 to avoid performance regression, so the bump won't update csv-filter.

9.4 PR has upgraded csv to 3.3.6 which has fixed the performance issue, so I think we don't need to udpate csv-filter in 9.4

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason it bumped for 8.19 and not 9.4 is that the new pin would have required the csv gem to bump at more than a --patch level for 9.4. The update here is harmless. I think this can ship as is, we can do another csv filter release that unpins if we want.

@andsel
andsel requested a review from alexcams August 4, 2026 15:21

@alexcams alexcams left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

logstash-core-plugin-api (>= 1.60, <= 2.99)
logstash-mixin-ecs_compatibility_support (~> 1.1)
logstash-filter-csv (3.1.1)
logstash-filter-csv (3.1.2)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason it bumped for 8.19 and not 9.4 is that the new pin would have required the csv gem to bump at more than a --patch level for 9.4. The update here is harmless. I think this can ship as is, we can do another csv filter release that unpins if we want.

java
universal-java-11
universal-java-17
universal-java-21

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like workflow run with main branch, I had open PR to align workflow branch on LS branch - #19343

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh sweet! I totally forgot about that. I'll review/approve. thanks

@donoghuc
donoghuc merged commit 19c0e41 into 8.19 Aug 4, 2026
6 checks passed
@donoghuc
donoghuc deleted the update_lock_8.19_1785847204 branch August 4, 2026 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants