[8.19] Mark ML controller non-dumpable before accepting commands (#3081)#3107
Merged
Conversation
* Mark ML controller non-dumpable before accepting commands Same-UID peers in the shared ES/ml-cpp pod could write /proc/<controller-pid>/mem and overwrite access@GOT so a spawn's access(path, X_OK) became dlopen(path, RTLD_LAZY) (elastic/security#12621). Call prctl(PR_SET_DUMPABLE, 0) after logging is up and before opening command pipes; verify with PR_GET_DUMPABLE and fail closed if the boundary cannot be established. No-op on non-Linux platforms where /proc/<pid>/mem is not the concern. Co-authored-by: Cursor <cursoragent@cursor.com> * Add changelog for #3081 Co-authored-by: Cursor <cursoragent@cursor.com> * [ML] Improve PR_GET_DUMPABLE diagnostic in controller non-dumpable guard Distinguish a PR_GET_DUMPABLE syscall failure (-1) from the process still being dumpable, and log the actual value, per review feedback on #3081. Co-authored-by: Cursor <cursoragent@cursor.com> * [ML] Remove public-to-private security-tracker references Co-authored-by: Cursor <cursoragent@cursor.com> * [ML] Fix clang-format in controller Main.cc Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Cursor <cursoragent@cursor.com> (cherry picked from commit 9c46fa0)
github-actions
Bot
added
backport
:ml
>bug
auto-backport
3 tasks
edsavage
approved these changes
Jul 24, 2026
edsavage
left a comment
edsavage
left a comment
Contributor
There was a problem hiding this comment.
Clean automated backport of an already-reviewed, approved change. Approving so auto-merge can complete.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.19:Questions ?
Please refer to the Backport tool documentation