[ML] Send version-bump Slack notification to #machine-learn-build and #ml-core - #3139
Merged
edsavage merged 2 commits intoAug 5, 2026
Merged
Conversation
… #ml-core Buildkite's slack notify accepts a list of channels; emit one YAML list item per channel and default to both #machine-learn-build and #ml-core. The ML_CPP_VERSION_BUMP_SLACK_CHANNEL override now takes a comma-separated list. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Pinging @elastic/ml-core (Team:ML) |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Buildkite version-bump Slack notification pipeline generator to support notifying multiple Slack channels from a single build, using Buildkite’s slack notifier channel list.
Changes:
- Extend
ML_CPP_VERSION_BUMP_SLACK_CHANNELto accept a comma-separated list (with trimming and empty-entry skipping). - Render the resulting channels as YAML list items and use them in both notification paths (minor freeze and patch bump).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…polation Each ML_CPP_VERSION_BUMP_SLACK_CHANNEL entry is now checked against an allowlist of characters valid for a Slack notify target (#chan, @user, IDs, [token]#chan) and the build fails fast on anything else, so a malformed override cannot emit invalid pipeline YAML or inject steps. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
send_slack_version_bump_notification.shposted the version-bump PR notification to a single channel (#machine-learn-build). Buildkite'sslacknotify already accepts a list of channels, so this renders one YAML list item per channel and defaults to both#machine-learn-buildand#ml-core.ML_CPP_VERSION_BUMP_SLACK_CHANNELnow takes a comma-separated list (was a single channel); entries are trimmed and empty ones skipped.Heads-up (operational)
Buildkite's Slack integration only delivers to channels the Buildkite Slack app is connected to — otherwise the post is silently dropped for that channel. #ml-core is a private channel, so the Buildkite Slack app must be explicitly invited (public #machine-learn-build works without it). Done — the app has now been added to #ml-core.
Test plan
bash -ncleanbuildkite-agentstub for bothWORKFLOW=patchandWORKFLOW=minor;channelsparses as['#machine-learn-build', '#ml-core']and the notify block is valid YAMLMade with Cursor