Skip to content

Conversation

@nastasha-solomon
Copy link
Contributor

@nastasha-solomon nastasha-solomon commented Jun 13, 2022

Fixes #2066.

Preview:

Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image looks good, I left a suggestion to improve the accuracy of the text.

nastasha-solomon and others added 2 commits June 18, 2022 09:40
Co-authored-by: benironside <91905639+benironside@users.noreply.github.com>
Copy link
Contributor

@joepeeples joepeeples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple small edits. Also super small issue, but the updated screenshot (alert-details-flyout.png) has a lot of empty space toward the bottom that could be cropped out fairly easily.

nastasha-solomon and others added 2 commits June 20, 2022 16:16
Copy link
Contributor

@jmikell821 jmikell821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look good to me -- I'm a +1 for Michael's suggestion. Adding the QA label for review tonight.

@jmikell821 jmikell821 added the readyforQA PRs that are ready for QA review. label Jun 22, 2022
@ghost
Copy link

ghost commented Jun 23, 2022

Hi @nastasha-solomon

we have validated this preview links for the respected changes and all changes are available and good to go.

Fixed Areas:

image

image

Hence we are adding "QA:Validated" tag to it.

thanks !!

@ghost ghost added QA:Validated Issue has been Validated by QA Team and removed readyforQA PRs that are ready for QA review. labels Jun 23, 2022
@nastasha-solomon nastasha-solomon merged commit a895d07 into main Jun 24, 2022
@nastasha-solomon nastasha-solomon deleted the issue-2066-session-id branch June 24, 2022 21:49
mergify bot pushed a commit that referenced this pull request Jun 24, 2022
…flyout (#2067)

Co-authored-by: benironside <91905639+benironside@users.noreply.github.com>
Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
(cherry picked from commit a895d07)
nastasha-solomon added a commit that referenced this pull request Jun 24, 2022
…tails flyout (backport #2067) (#2147)

Co-authored-by: benironside <91905639+benironside@users.noreply.github.com>
Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature: Alerts QA:Validated Issue has been Validated by QA Team Team: Docs Team: Threat Hunting Formerly Data Visibility v8.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DOCS] Add session ID to highlighted fields section in alert details flyout

7 participants