Skip to content

[DOCS] Add the "investigate in timeline" button to the alert prevalence section #2077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Jun 24, 2022
Merged

[DOCS] Add the "investigate in timeline" button to the alert prevalence section #2077

merged 17 commits into from
Jun 24, 2022

Conversation

@nastasha-solomon
Copy link
Contributor

@nastasha-solomon nastasha-solomon commented Jun 16, 2022 •
edited
Loading

Fixes #2065.

Preview:

@nastasha-solomon nastasha-solomon self-assigned this Jun 16, 2022
@nastasha-solomon nastasha-solomon marked this pull request as ready for review June 16, 2022 19:58
@nastasha-solomon nastasha-solomon mentioned this pull request Jun 16, 2022
Closed
15 tasks
benironside
benironside reviewed Jun 16, 2022
View reviewed changes
Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left one minor suggestion.

nastasha-solomon and others added 2 commits June 18, 2022 09:39
@nastasha-solomon @benironside
Update docs/detections/alerts-ui-manage.asciidoc
dd3b70f 
Co-authored-by: benironside <91905639+benironside@users.noreply.github.com>
@nastasha-solomon
Merge branch 'main' into issue-2065-alert-prev-time
5cfe2d9
joepeeples
joepeeples approved these changes Jun 20, 2022
View reviewed changes
Copy link
Contributor

@joepeeples joepeeples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I added some totally optional suggestions for tightening up the paragraph.

@nastasha-solomon @joepeeples
Update docs/detections/alerts-ui-manage.asciidoc
e17750c 
Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
michaelolo24
michaelolo24 reviewed Jun 21, 2022
View reviewed changes
michaelolo24
michaelolo24 approved these changes Jun 21, 2022
View reviewed changes
Copy link

@michaelolo24 michaelolo24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 LGTM!

@nastasha-solomon nastasha-solomon added the readyforQA PRs that are ready for QA review. label Jun 22, 2022
@nastasha-solomon nastasha-solomon mentioned this pull request Jun 22, 2022
Merged
jmikell821
jmikell821 approved these changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@jmikell821 jmikell821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for merging in feedback :-) We'll wait for QA to do a final review.

@ghost
Copy link

ghost commented Jun 23, 2022

#2077

Hi @nastasha-solomon

we have validated this preview links for the respected changes and all changes are available and good to go.

Fixed Areas:

image

image

@ghost ghost removed the readyforQA PRs that are ready for QA review. label Jun 23, 2022
@ghost ghost added the QA:Validated Issue has been Validated by QA Team label Jun 23, 2022
@mergify
Copy link
Contributor

mergify bot commented Jun 24, 2022

This pull request is now in conflicts. Could you fix it @nastasha-solomon? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b issue-2065-alert-prev-time upstream/issue-2065-alert-prev-time
git merge upstream/main
git push upstream issue-2065-alert-prev-time

@nastasha-solomon nastasha-solomon merged commit 9da2d9d into main Jun 24, 2022
@nastasha-solomon nastasha-solomon deleted the issue-2065-alert-prev-time branch June 24, 2022 22:20
mergify bot pushed a commit that referenced this pull request Jun 24, 2022
@nastasha-solomon @benironside
@joepeeples @mergify
[DOCS] Add the "investigate in timeline" button to the alert prevalen…
7a06d7d 
…ce section (#2077)

Co-authored-by: benironside <91905639+benironside@users.noreply.github.com>
Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
(cherry picked from commit 9da2d9d)
@mergify mergify bot mentioned this pull request Jun 24, 2022
Merged
nastasha-solomon added a commit that referenced this pull request Jun 24, 2022
@mergify @benironside
@joepeeples @nastasha-solomon
[8.3] [DOCS] Add the "investigate in timeline" button to the alert pr…
212edbe 
…evalence section (backport #2077) (#2148)

Co-authored-by: benironside <91905639+benironside@users.noreply.github.com>
Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benironside benironside benironside left review comments

@janmonschke janmonschke janmonschke approved these changes

@michaelolo24 michaelolo24 michaelolo24 approved these changes

@jmikell821 jmikell821 jmikell821 approved these changes

+1 more reviewer

@joepeeples joepeeples joepeeples approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@nastasha-solomon nastasha-solomon

Labels

Feature: Alerts QA:Validated Issue has been Validated by QA Team Team: Docs Team: Threat Hunting Formerly Data Visibility v8.3.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[DOCS] Add the "investigate in timeline" button to the alert prevalence section

7 participants

@nastasha-solomon @janmonschke @michaelolo24 @jmikell821 @joepeeples @benironside