[DOCS] Threat Intelligence - Indicators Page and Indicator Details #2526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation previews: |
nastasha-solomon
requested review from
benironside,
dhru42,
jmikell821,
joepeeples and
maxcold
benironside
reviewed
Oct 4, 2022
Contributor
benironside
left a comment
benironside
left a comment
There was a problem hiding this comment.
Overall looks great 🚀 . Left a few sentence-level suggestions.
Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
Contributor
Author
nastasha-solomon
left a comment
nastasha-solomon
left a comment
There was a problem hiding this comment.
Additional edits from joe and dhru
|
We have reviewed the shared preview for Threat Intelligence - Indicators Page and Indicator Details and all the required changes are present and correct. ✔️ Screenshots: Indicators.of.compromise._.Elastic.Security.Solution.master._.Elastic.-.Google.Chrome.2022-10-18.13-23-54.mp4Hence we are adding "QA:Validated" label to it. Thanks! |
ghost
added
QA:Validated
jmikell821
reviewed
Oct 18, 2022
Contributor
jmikell821
left a comment
jmikell821
left a comment
There was a problem hiding this comment.
Two slight nits, then good to go! Thanks!
Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com>
Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com>
mergify bot
pushed a commit
that referenced
this pull request
Oct 18, 2022
…2526) Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> Co-authored-by: Joe Peeples <joe.peeples@elastic.co> Co-authored-by: Maxim Kholod <mxcold@gmail.com> Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com> (cherry picked from commit 16180a9)
nastasha-solomon
added a commit
that referenced
this pull request
Oct 18, 2022
…ils (backport #2526) (#2598) Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> Co-authored-by: Joe Peeples <joe.peeples@elastic.co> Co-authored-by: Maxim Kholod <mxcold@gmail.com> Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com> Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2497.
Previews: