[DOCS] Elastic Security UI updates #2594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation previews: |
Might need adjusting once security-docs#2526 merges
joepeeples
requested review from
benironside,
jmikell821 and
nastasha-solomon
benironside
reviewed
Oct 18, 2022
Contributor
benironside
left a comment
benironside
left a comment
There was a problem hiding this comment.
Couple of minor line edits, otherwise LGTM!
| [float] | ||
| === Intelligence | ||
|
|
||
| The Intelligence section contains the Indicators page, which collects data from enabled threat intelligence feeds and provides a centralized view of indicators of compromise (IoCs). Refer to <<investigate-events>> to learn more. |
Contributor
There was a problem hiding this comment.
Suggested change
| The Intelligence section contains the Indicators page, which collects data from enabled threat intelligence feeds and provides a centralized view of indicators of compromise (IoCs). Refer to <<investigate-events>> to learn more. | |
| The Intelligence section contains the Indicators page, which displays data from enabled threat intelligence feeds and provides a centralized view of indicators of compromise (IoCs). Refer to <<investigate-events>> to learn more. |
Collect seems to me like something that server agents do
Contributor
Author
There was a problem hiding this comment.
@benironside I think it's trying convey that the page gathers data from disparate sources/feeds and presents them in a single place. "Displays" sounds more general, like the data might have already been there, it just needed to be displayed.
@nastasha-solomon Any preference? This description was lifted from your PR on the Indicators page.
Contributor
There was a problem hiding this comment.
Hm, I see your point @benironside but think I'd still prefer to keep "collects". The second part of the sentence already tells users that the Indicators page displays data ingested from enabled threat feeds.
Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
mergify bot
pushed a commit
that referenced
this pull request
Oct 19, 2022
* First draft * Placeholder image for Indicators page Might need adjusting once security-docs#2526 merges * Apply suggestions from Ben's review Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> * Remove extra line Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> (cherry picked from commit 51c93f8)
joepeeples
added a commit
that referenced
this pull request
Oct 19, 2022
* First draft * Placeholder image for Indicators page Might need adjusting once security-docs#2526 merges * Apply suggestions from Ben's review Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> * Remove extra line Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> (cherry picked from commit 51c93f8) Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2547.
main). The link currently points to the Investigate landing page to keep CI from breaking.Preview: These subsections in the Elastic Security UI topic: