[ML] show expected model outputs for each nlp task type #2112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcawl
reviewed
Apr 25, 2022
Contributor
lcawl
left a comment
lcawl
left a comment
There was a problem hiding this comment.
I've added some more suggestions and comments...
Co-authored-by: Lisa Cawley <lcawley@elastic.co>
…m:benwtrent/stack-docs into feature/ml-clarify-nlp-model-task-outputs
lcawl
approved these changes
Apr 26, 2022
Contributor
lcawl
left a comment
lcawl
left a comment
There was a problem hiding this comment.
Three minor suggestions, otherwise LGTM
Co-authored-by: Lisa Cawley <lcawley@elastic.co>
davidkyle
reviewed
Apr 27, 2022
Member
davidkyle
left a comment
davidkyle
left a comment
There was a problem hiding this comment.
My preference would be not to have the output description interleaved in the list of models. Could they go in a separate section at the end so the list is supported models is uninterrupted and easier to scan. That list of models is the main reason people visit this page
Member
Author
|
@lcawl what do you think? ^ |
mergify bot
pushed a commit
that referenced
this pull request
Apr 28, 2022
* [ML] show expected model outputs for each nlp task type Co-authored-by: Lisa Cawley <lcawley@elastic.co> Co-authored-by: lcawl <lcawley@elastic.co> (cherry picked from commit ff07d25)
benwtrent
added a commit
that referenced
this pull request
Apr 28, 2022
* [ML] show expected model outputs for each nlp task type Co-authored-by: Lisa Cawley <lcawley@elastic.co> Co-authored-by: lcawl <lcawley@elastic.co> (cherry picked from commit ff07d25) Co-authored-by: Benjamin Trent <benjamin.trent@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview
https://stack-docs_2112.docs-preview.app.elstc.co/guide/en/machine-learning/master/ml-nlp-model-ref.html