Update uninstall command to return to previous directory#84
Update uninstall command to return to previous directory#84ezimuel merged 1 commit intoelastic:mainfrom
Conversation
When using it, I have to "manually" cd back to the previous dir. I suggest that the instructions automatically cd back to the previous dir.
|
@dadoonet the command that you updated is just an echo, it doesn't produce any effect. I don't think it's so relevant to add it as suggestion, the point is to inform users that they need to go inside the folder and execute the |
|
Yes. It's just a "documentation" PR. What the user is normally doing is something like: curl -fsSL https://elastic.co/start-local | shBut then you are getting this message: So the user copy paste and run: cd elastic-start-local && ./uninstall.shThen he goes to the history and run: curl -fsSL https://elastic.co/start-local | shWhich installs start-local in Instead, if the user runs: cd elastic-start-local && ./uninstall.sh && cd -
curl -fsSL https://elastic.co/start-local | shAll would be good IMHO. Again, minor change but because I hit this and did not really notice that I was not in the right "dir", I thought I'd propose a change. |
|
Or may be we should have one of those commands: curl -fsSL https://elastic.co/start-local | sh -s -- --uninstall
curl -fsSL https://elastic.co/start-local | sh -s -- --force |
|
Ok, I got it. Never do copy & paste 😄 |
ezimuel
left a comment
There was a problem hiding this comment.
LGTM, thanks for the PR.
When using it, I have to "manually" cd back to the previous dir. I suggest that the instructions automatically cd back to the previous dir.