Adding opts.attrs and opts.text.

[jsdevel]

Some of the 3rd party libraries my team mates have been dealing with require text nodes in the script tag and / or attributes. This PR adds support for this.

[joshuajohnson814]

+1

[tylerkayser]

+1

[vvo]

We could also just return the script DOM node, what you do with it is then up to you. Add text node, attributes.

[vvo]

This would not add features for a small need.

[jsdevel]

@vvo by then it's too late as the libs we're calling sometimes require attributes on the script tag that loaded them while the js is executing E.G. before onload has fired.

[vvo]

But creating a script tag is synchronous compared to doing the actual script request. So if you add attributes right after using loadScript which returns the dom element, it should always work right?

[vvo]

Maybe if there's a cached version you are screwed, dunno.

[jsdevel]

I can see cases where {async: false} may be needed so the third parameter doesn't seem too far off to me.

[defunctzombie]

If there is no way to hack around this then we should have the options.

Separately, the PR needs to update the README with new features.

[jsdevel]

@defunctzombie Readme.md updated. Let me know if you'd like the format changed.

Also, if there is a way to hack around this then I'm completely open to it.

[vvo]

@jsdevel As for the async atribute, you are right, let's add this feature :)

[jsdevel]

@vvo tests added for opts.async, opts.charset, and opts.type.

[jsdevel]

@vvo @defunctzombie are there any other tweaks you'd like me to make?

[defunctzombie]

LGTM

[vvo]

👍 But I am no maintainer :)

[defunctzombie]

@jsdevel

<internet explorer 6 on Windows 2003> opts.text
Error: Unexpected call to method or property access.

Tests fail on old IE (6,7,8).

Please take a look and fix this up otherwise will have to revert since my goal with this is to have it work on all browsers.

[vvo]

@jsdevel either setAttribute or createTextNode are failing I guess.

[jsdevel]

Looking now...

[jsdevel]

Firing up my vista VM to test in IE8...