Fix for "Deploy to Heroku" button#154
Merged
electerious merged 1 commit intoelecterious:developfrom Sep 8, 2020
katriellucas:heroku-fix
Merged
Fix for "Deploy to Heroku" button#154electerious merged 1 commit intoelecterious:developfrom katriellucas:heroku-fix
electerious merged 1 commit intoelecterious:developfrom
katriellucas:heroku-fix
Conversation
Owner
|
Thanks @Go-Merk! @aleccool213 You're my Heroku specialist 😃 Does this look good to you? |
aleccool213
approved these changes
Sep 7, 2020
| "description": "Password which will be used to log in to Ackee", | ||
| "required": true | ||
| }, | ||
| "ACKEE_MONGODB": { |
Contributor
There was a problem hiding this comment.
Good idea putting this in. I didn't originally put this in because the add-on put in a mongo db uri env var automatically.
| "required": false | ||
| } | ||
| }, | ||
| "addons": [ |
Contributor
There was a problem hiding this comment.
Is there docs saying which third party mongo dbs are best to use?
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the title says, removed the deprecated dependecies (mLab addon), added some important (I think) environment variables in the the app creation. Now you directly need to link a database (e.g., MongoDB Atlas) to use Ackee.
Here is an example button: