fix pressed key checking#1488
Closed
damosse31 wants to merge 2 commits intoelecterm:masterfrom
damosse31:fix-pressed-key
Closed
fix pressed key checking#1488damosse31 wants to merge 2 commits intoelecterm:masterfrom damosse31:fix-pressed-key
damosse31 wants to merge 2 commits intoelecterm:masterfrom
damosse31:fix-pressed-key
Conversation
Use .key event property instead of .code to avoid differences in keyboard disposition (eg QWERTY vs AZERTY)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use .key event property instead of .code to avoid differences in keyboard disposition (eg QWERTY vs AZERTY)
For example, in my case the W key on my AZERTY keyboard is inverted with your Z QWERTY keyboard. So with this fix, the real pressed letter is checked.
https://developer.mozilla.org/en/docs/Web/API/KeyboardEvent/code