Fix missing data in release comments #3583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e comments The release notification comments were missing package data because backticks in the body text (e.g., `@electric-sql/client@1.2.8`) were being interpreted by the shell as command substitution. This caused the package names to be replaced with empty strings. Fix by using gh's --body-file - flag to pass the body via stdin, avoiding shell interpretation entirely. Fixes comments like #3547 (comment)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3583 +/- ##
==========================================
+ Coverage 61.72% 62.04% +0.32%
==========================================
Files 40 40
Lines 1557 1557
Branches 105 104 -1
==========================================
+ Hits 961 966 +5
+ Misses 595 590 -5
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alco
approved these changes
Dec 11, 2025
KyleAMathews
deleted the
claude/debug-missing-comment-data-01MmpVQqNNzypxehLQNcumxP
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The release notification comments were missing package data because backticks in the body text (e.g.,
@electric-sql/client@1.2.8) were being interpreted by the shell as command substitution. This caused the package names to be replaced with empty strings.Fix by using gh's --body-file - flag to pass the body via stdin, avoiding shell interpretation entirely.
Fixes comments like #3547 (comment)