Skip to content

Preserve Cloud auth dispatcher when enabling fetch cache#4524

Merged
KyleAMathews merged 1 commit into
mainfrom
fix-desktop-cloud-auth-dispatcher
Jun 6, 2026
Merged

Preserve Cloud auth dispatcher when enabling fetch cache#4524
KyleAMathews merged 1 commit into
mainfrom
fix-desktop-cloud-auth-dispatcher

Conversation

@KyleAMathews

Copy link
Copy Markdown
Contributor

Summary

  • compose the Durable Streams fetch cache on top of the existing undici global dispatcher instead of replacing it
  • preserve Electric Agents Desktop's Cloud auth header injector after the built-in agents runtime starts
  • add a regression test for dispatcher composition

Testing

  • pnpm --filter @electric-ax/agents test test/durable-streams-cache.test.ts
  • pnpm --filter @electric-ax/agents typecheck
  • pnpm --filter @electric-ax/agents build

Notes

Debugging showed Cloud setup succeeded, but after the built-in agents runtime installed the Durable Streams cache, subsequent Cloud requests lost Authorization and returned 401 {"error":"Missing bearer token"}.

@github-actions

github-actions Bot commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

Electric Agents Desktop Builds

Build artifacts for commit 9af0786.

Platform Status Artifact
macOS Apple Silicon Passed DMG
macOS Intel Passed DMG
Windows x64 Passed Installer
Linux x64 Passed AppImage / deb

Workflow run

@codecov

codecov Bot commented Jun 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.36%. Comparing base (6e87257) to head (9af0786).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4524       +/-   ##
===========================================
+ Coverage   54.72%   69.36%   +14.63%     
===========================================
  Files         311       78      -233     
  Lines       35845     9319    -26526     
  Branches    10251     2907     -7344     
===========================================
- Hits        19617     6464    -13153     
+ Misses      16209     2837    -13372     
+ Partials       19       18        -1     
Flag Coverage Δ
packages/agents 71.62% <ø> (ø)
packages/agents-mobile ?
packages/agents-runtime ?
packages/agents-server 72.87% <ø> (+0.01%) ⬆️
packages/agents-server-ui ?
packages/electric-ax 46.42% <ø> (ø)
typescript 69.36% <ø> (+14.63%) ⬆️
unit-tests 69.36% <ø> (+14.63%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@samwillis samwillis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KyleAMathews KyleAMathews merged commit 8bcadb7 into main Jun 6, 2026
29 checks passed
@KyleAMathews KyleAMathews deleted the fix-desktop-cloud-auth-dispatcher branch June 6, 2026 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants