fix(examples): drop trailing slash from /v1/shape URLs (fixes yjs demo)#4724
Merged
Merged
Conversation
The Electric Cloud API returns 404 ROUTE_NOT_FOUND for /v1/shape/
(with a trailing slash). This broke the deployed yjs demo — the
shape proxy at yjs-server.examples.electric-sql.com forwarded every
request to ${ELECTRIC_URL}/v1/shape/ and passed the 404 through,
leaving the editor permanently disconnected.
Same latent issue fixed in linearlite-read-only's client-side shape
config.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
thruflo
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
One-character fix in two examples:
${ELECTRIC_URL}/v1/shape/→${ELECTRIC_URL}/v1/shape.Why
The Electric Cloud API returns
404 {"error":{"code":"ROUTE_NOT_FOUND"}}for/v1/shape/with a trailing slash (without the slash it routes fine).This is currently breaking the deployed yjs demo (linked from https://electric-sql.com/sync/demos/yjs): the shape proxy at
yjs-server.examples.electric-sql.com/shape-proxy/v1/shapeforwards tohttps://api.electric-sql.cloud/v1/shape/and passes the 404 through, so the editor loads but stays permanentlydisconnected, retrying in a loop.Verified against the live API:
The same latent pattern existed in
linearlite-read-only's client-side shape config, fixed here too.Deploy
The yjs demo needs a redeploy of the
yjsexample service after this merges for the fix to take effect.🤖 Generated with Claude Code