fix: pg-sync #435
Merged
fix: pg-sync #435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Contributor
|
🚀 Deployed on https://6745d2c62cc71f562ba518d0--pglite.netlify.app |
samwillis
requested changes
Nov 25, 2024
Collaborator
samwillis
left a comment
samwillis
left a comment
There was a problem hiding this comment.
Looking good, just a few small tweaks.
I think the mock ignores the table option, we should look at fixing that, along with e2e tests.
Let's get this merged and solve other things later.
Co-authored-by: Sam Willis <sam.willis@gmail.com>
Co-authored-by: Sam Willis <sam.willis@gmail.com>
Co-authored-by: Sam Willis <sam.willis@gmail.com>
Co-authored-by: Sam Willis <sam.willis@gmail.com>
yacineb
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.