fix: buffer emitWithAck until (re)connect - #80
Merged
Conversation
ClientSocket.emit buffers when not connected and replays on (re)connect, but emitWithAck sent to this.serverSocket directly. While disconnected that delivered to the dead previous socket and leaked the pending-ack rejecter; before the first connect it dereferenced an undefined socket. Add the same not-connected guard: buffer the call with its trailing ack callback into sendBuffer, so completeConnection replays it to the (re)connected socket and the ack still settles, matching socket.io-client.
Pin the socket.io-client behavior first: an emitWithAck issued while disconnected buffers and settles after reconnect. Passes on the real target and failed on the mock before the fix.
This was referenced Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ClientSocket.emitbuffers when not connected and replays on (re)connect, butemitWithAcksent tothis.serverSocketdirectly. While disconnected that delivered to the dead previous socket and leaked the pending-ack rejecter; before the first connect it dereferenced an undefined socket.This adds the same not-connected guard to
emitWithAck: it buffers the call (with its trailing ack callback) intosendBuffer, socompleteConnectionreplays it to the (re)connected socket and the ack still settles, matching socket.io-client.Related issue
Closes #57
Checklist
The new conformance test in
ack.test.tswas pinned against the real target first (it passes there) and failed on the mock before the fix. Both targets are green now.