fix(deployment): ensure that we await update meta files publishing

Author: develar

packages/electron-builder/src/publish/PublishManager.ts

@@ -157,15 +157,20 @@ export class PublishManager implements PublishContext {
     this.nameToPublisher.clear()
   }
 
+  // noinspection InfiniteRecursionJS
   async awaitTasks(): Promise<void> {
     await this.taskManager.awaitTasks()
     if (!this.cancellationToken.cancelled) {
+      if (this.postponedArtifactCreatedEvents.length === 0) {
+        return
+      }
+
       const events = this.postponedArtifactCreatedEvents.slice()
       this.postponedArtifactCreatedEvents.length = 0
       for (const event of events) {
         this.packager.dispatchArtifactCreated(event)
       }
-      await this.taskManager.awaitTasks()
+      await this.awaitTasks()
     }
   }
 }

packages/electron-publisher-s3/src/BaseS3Publisher.ts

@@ -59,7 +59,7 @@ export abstract class BaseS3Publisher extends Publisher {
       })
     }
 
-    return cancellationToken.createPromise((resolve, reject, onCancel) => {
+    return await cancellationToken.createPromise((resolve, reject, onCancel) => {
       onCancel(() => uploader.abort())
       uploader.upload()
         .then(() => {

test/src/helpers/fileAssert.ts

@@ -1,5 +1,5 @@
 import { exists, statOrNull } from "builder-util/out/fs"
-import { lstat, stat } from "fs-extra-p"
+import { lstat } from "fs-extra-p"
 import * as path from "path"
 
 // http://joel-costigliola.github.io/assertj/
@@ -39,9 +39,13 @@ class Assertions {
   }
 
   async isDirectory() {
-    const info = await stat(this.actual)
+    const file = this.actual
+    const info = await statOrNull(file)
+    if (info == null) {
+      throw new Error(`Path ${file} doesn't exist`)
+    }
     if (!info.isDirectory()) {
-      throw new Error(`Path ${this.actual} is not a directory`)
+      throw new Error(`Path ${file} is not a directory`)
     }
   }