Skip to content

chore(test): run Windows auto-update e2e tests via Parallels VM on macOS#9727

Merged
mmaietta merged 3 commits into
masterfrom
chore/vm-assisted-tests
May 12, 2026
Merged

chore(test): run Windows auto-update e2e tests via Parallels VM on macOS#9727
mmaietta merged 3 commits into
masterfrom
chore/vm-assisted-tests

Conversation

@mmaietta
Copy link
Copy Markdown
Collaborator

Extends the blackbox updater test suite so that NSIS/Windows tests can run directly from a macOS host using an existing Parallels Windows VM, without needing a native Windows runner.

  • Searches for an available Parallels Windows VM at module load via getWindowsVm() IIFE; if found, Windows build/install/update steps are routed through it
  • Writes a temporary update config to ~/ (mapped as \\Mac\Home\ in the VM — always shared) rather than system temp (\\Mac\Host\private\var\folders\... which requires "All Disks" sharing)
  • Serves the NSIS installer over HTTP from the macOS host so the VM can download it without relying on slow UNC file reads for large binaries. Includes SHA-256 integrity verification of the downloaded installer before execution

@mmaietta mmaietta requested a review from Copilot May 12, 2026 06:33
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 12, 2026

⚠️ No Changeset found

Latest commit: ff23c39

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the updater blackbox E2E test harness to support running Windows/NSIS auto-update flows from a macOS host by delegating install/launch steps into a Parallels Windows VM, and adjusts the test fixture app/logging to be more VM/headless-friendly.

Changes:

  • Add Parallels VM discovery + VM-aware install/launch paths for NSIS tests, plus HTTP-based delivery and SHA-256 verification for large installers.
  • Update local HTTP server helper to support binding to non-loopback interfaces and add a helper to detect the Parallels host IP.
  • Adjust the test fixture app to run headlessly (no window) during auto-update and to emit logs in a way that can be captured reliably.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
test/src/windows/winReseditTest.ts Switch import to app-builder-lib/out/... for resource editing helper.
test/src/updater/blackboxUpdateTest.ts Add VM routing, HTTP installer delivery + hashing, VM config placement, and longer polling for NSIS update completion.
test/src/rebuilderTest.ts Switch exists import to builder-util/out/....
test/src/helpers/launchAppCrossPlatform.ts Add Parallels host IP detection, allow server bind address override, and add VM-based execution path.
test/snapshots/globTest.js.snap Update snapshot offsets/sizes due to fixture output changes.
test/fixtures/test-app/app/index.js Make updater test app headless-friendly and adjust logging/error handling for reliable stdout capture.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread test/src/updater/blackboxUpdateTest.ts Outdated
Comment thread test/src/updater/blackboxUpdateTest.ts Outdated
Comment thread test/src/updater/blackboxUpdateTest.ts Outdated
Comment thread test/src/updater/blackboxUpdateTest.ts
Comment thread test/src/updater/blackboxUpdateTest.ts
Comment thread test/src/updater/blackboxUpdateTest.ts Outdated
Comment thread test/src/helpers/launchAppCrossPlatform.ts
@mmaietta mmaietta marked this pull request as ready for review May 12, 2026 13:56
@mmaietta mmaietta merged commit 9dcb456 into master May 12, 2026
62 of 63 checks passed
@mmaietta mmaietta deleted the chore/vm-assisted-tests branch May 12, 2026 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants