feat: build the s390x sysroot - #86
Merged
Merged
Conversation
VerteDinde
approved these changes
Sep 3, 2026
MarshallOfSound
approved these changes
Sep 3, 2026
Upstream added s390x in https://chromium.googlesource.com/chromium/src/+/3611afaf32d54680a54b5985d9127ffc6833af59; build and upload it here as well so the scripts stay in step with Chromium's.
codebytere
force-pushed
the
add-s390x
branch
from
September 4, 2026 07:31
a99fc06 to
6b2893a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #85.
Builds and uploads the s390x (bullseye) sysroot that upstream added in
3611afa/cf57159: theRELEASES/APT_SOURCES_LISTS/TRIPLESentries, a matrix leg withbinutils-s390x-linux-gnu, the README arch list, and the generated package list (upstream's plus our libnotify packages; the build rewrites it anyway). Electron has no s390x target today, so this is for parity with Chromium's scripts rather than a release;install-sysroot.pyis left as upstream has it, without s390x inVALID_ARCHS.