feat: dynamic ESM import in preload without context isolation#48375
Merged
codebytere merged 1 commit intoelectron:mainfrom Oct 8, 2025
Merged
Conversation
indutny-signal
changed the title
Member
|
Can you rebase on latest |
deepak1556
added
semver/minor
deepak1556
added
target/37-x-y
indutny-signal
force-pushed
the
feature/esm-in-non-context-isolated-preload
branch
from
f8fd799 to
eefce0c
Compare
Contributor
Author
|
@deepak1556 you got it! |
deepak1556
reviewed
Sep 25, 2025
indutny-signal
force-pushed
the
feature/esm-in-non-context-isolated-preload
branch
from
eefce0c to
652f656
Compare
Extend `HostImportModuleWithPhaseDynamically`'s routing to support Node.js import resolution in non-context-isolated preloads through `v8_host_defined_options` length check. The length of host defined options is distinct between Blink and Node.js and we can use it to determine which resolver to use.
indutny-signal
force-pushed
the
feature/esm-in-non-context-isolated-preload
branch
from
652f656 to
475a0a7
Compare
codebytere
approved these changes
Sep 26, 2025
Member
|
API LGTM |
electron-cation
bot
added
api-review/approved ✅
and removed
api-review/requested 🗳
labels
|
Release Notes Persisted
|
This was referenced Oct 8, 2025
Contributor
|
I have automatically backported this PR to "37-x-y", please check out #48487 |
Contributor
|
I have automatically backported this PR to "39-x-y", please check out #48488 |
Contributor
|
I have automatically backported this PR to "38-x-y", please check out #48489 |
trop
bot
added
in-flight/37-x-y
in-flight/39-x-y
in-flight/38-x-y
and removed
target/37-x-y
Contributor
Author
|
Thank you everyone! |
trop
bot
added
merged/39-x-y
TheCommieAxolotl
pushed a commit
to TheCommieAxolotl/electron
that referenced
this pull request
Nov 2, 2025
…on#48375) Dynamic ESM import in non-context-isolated preload Extend `HostImportModuleWithPhaseDynamically`'s routing to support Node.js import resolution in non-context-isolated preloads through `v8_host_defined_options` length check. The length of host defined options is distinct between Blink and Node.js and we can use it to determine which resolver to use.
nilayarya
pushed a commit
to nilayarya/electron
that referenced
this pull request
Nov 21, 2025
…on#48375) Dynamic ESM import in non-context-isolated preload Extend `HostImportModuleWithPhaseDynamically`'s routing to support Node.js import resolution in non-context-isolated preloads through `v8_host_defined_options` length check. The length of host defined options is distinct between Blink and Node.js and we can use it to determine which resolver to use.
nilayarya
added a commit
to nilayarya/electron
that referenced
this pull request
Nov 21, 2025
…on#48375) Dynamic ESM import in non-context-isolated preload Extend `HostImportModuleWithPhaseDynamically`'s routing to support Node.js import resolution in non-context-isolated preloads through `v8_host_defined_options` length check. The length of host defined options is distinct between Blink and Node.js and we can use it to determine which resolver to use.
nilayarya
added a commit
to nilayarya/electron
that referenced
this pull request
Nov 21, 2025
…on#48375) Dynamic ESM import in non-context-isolated preload Extend `HostImportModuleWithPhaseDynamically`'s routing to support Node.js import resolution in non-context-isolated preloads through `v8_host_defined_options` length check. The length of host defined options is distinct between Blink and Node.js and we can use it to determine which resolver to use.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Extend
HostImportModuleWithPhaseDynamically's routing to support Node.js import resolution in non-context-isolated preloads throughv8_host_defined_optionslength check. The length of host defined options is distinct between Blink and Node.js and we can use it to determine which resolver to use.Checklist
npm testpassesRelease Notes
Notes: Support dynamic ESM imports in non-context isolated preloads
cc @MarshallOfSound