fix: allow disabling all `NSMenuItems` by codebytere · Pull Request #48598 · electron/electron

codebytere · 2025-10-20T08:53:15Z

Description of Change

Reworks menu item validation to manual management and not the confusing combination of automatic and manual management that's been in use up to now. As it stood, menu items with default system-defined selectors didn't call validateUserInterfaceItem as this class was not where those were defined.

This was previously tried in #46307, but with the missing understanding that disabling autoenablesItems meant validateUserInterfaceItem would no longer be called under any circumstances, and this we need to now shift this logic to menuWillShow and call it ourselves.

Confirmed not to regress #46501, #46593, or #46485

Checklist

PR description included and stakeholders cc'd
npm test passes
PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

Notes: Fixed an issue that menu items on macOS could not be disabled under all circumstances.

nikwen · 2025-10-23T17:41:09Z

Confirmed not to regress #46501, #46593, or #46485

Thanks for confirming that it doesn't regress those bugs!

release-clerk · 2025-10-28T15:20:58Z

Release Notes Persisted

Fixed an issue that menu items on macOS could not be disabled under all circumstances.

trop · 2025-10-28T15:21:23Z

I have automatically backported this PR to "38-x-y", please check out #48710

trop · 2025-10-28T15:21:32Z

I have automatically backported this PR to "39-x-y", please check out #48711

trop · 2025-10-28T15:21:36Z

I have automatically backported this PR to "37-x-y", please check out #48712

This reverts commit 0cb4fdd. Co-authored-by: Keeley Hammond <khammond@slack-corp.com>

Revert "fix: allow disabling all `NSMenuItems` (#48598)" This reverts commit 0cb4fdd. Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Keeley Hammond <khammond@slack-corp.com>

This reverts commit 0cb4fdd. Co-authored-by: Keeley Hammond <khammond@slack-corp.com>

Revert "fix: allow disabling all `NSMenuItems` (#48598)" This reverts commit 0cb4fdd. Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Keeley Hammond <khammond@slack-corp.com>

* fix: allow disabling all `NSMenuItems` (#48598) fix: allow disabling all NSMenuItems * fix: add guard for type --------- Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

fix: allow disabling all NSMenuItems Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

Revert "fix: allow disabling all `NSMenuItems` (#48598)" This reverts commit 0cb4fdd. Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Keeley Hammond <khammond@slack-corp.com>

* fix: allow disabling all `NSMenuItems` (#48598) fix: allow disabling all NSMenuItems Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> * fix: add guard for type Co-authored-by: George Xu <george.xu@slack-corp.com> --------- Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> Co-authored-by: George Xu <george.xu@slack-corp.com>

* fix: allow disabling all `NSMenuItems` (#48598) fix: allow disabling all NSMenuItems * fix: add guard for type --------- Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> (cherry picked from commit 38be633)

* fix: add guard for type Co-authored-by: George Xu <george.xu@slack-corp.com> * fix(reland): allow disabling all `NSMenuItems` (#48795) * fix: allow disabling all `NSMenuItems` (#48598) fix: allow disabling all NSMenuItems * fix: add guard for type --------- Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> (cherry picked from commit 38be633) --------- Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: George Xu <george.xu@slack-corp.com> Co-authored-by: George Xu <33054982+georgexu99@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

fix: allow disabling all NSMenuItems

…#48794) Revert "fix: allow disabling all `NSMenuItems` (electron#48598)" This reverts commit 0cb4fdd.

* fix: allow disabling all `NSMenuItems` (electron#48598) fix: allow disabling all NSMenuItems * fix: add guard for type --------- Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

fix: allow disabling all NSMenuItems

…#48794) Revert "fix: allow disabling all `NSMenuItems` (electron#48598)" This reverts commit 0cb4fdd.

* fix: allow disabling all `NSMenuItems` (electron#48598) fix: allow disabling all NSMenuItems * fix: add guard for type --------- Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

fix: allow disabling all NSMenuItems

…#48794) Revert "fix: allow disabling all `NSMenuItems` (electron#48598)" This reverts commit 0cb4fdd.

* fix: allow disabling all `NSMenuItems` (electron#48598) fix: allow disabling all NSMenuItems * fix: add guard for type --------- Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

fix: allow disabling all NSMenuItems

54591c5

codebytere requested review from MarshallOfSound, dsanders11 and jkleinsc October 20, 2025 08:53

codebytere added the semver/patch backwards-compatible bug fixes label Oct 20, 2025

electron-cation bot added new-pr 🌱 PR opened recently and removed new-pr 🌱 PR opened recently labels Oct 20, 2025

ckerr approved these changes Oct 28, 2025

View reviewed changes

ckerr mentioned this pull request Oct 28, 2025

refactor: remove redundant map lookups in browser/api/menu.ts #48706

Merged

3 tasks

jkleinsc approved these changes Oct 28, 2025

View reviewed changes

jkleinsc added target/37-x-y PR should also be added to the "37-x-y" branch. target/38-x-y PR should also be added to the "38-x-y" branch. target/39-x-y PR should also be added to the "39-x-y" branch. labels Oct 28, 2025

jkleinsc merged commit 0cb4fdd into main Oct 28, 2025
158 of 160 checks passed

jkleinsc deleted the fix-enabled branch October 28, 2025 15:20

This was referenced Oct 28, 2025

fix: allow disabling all NSMenuItems #48710

Merged

fix: allow disabling all NSMenuItems #48711

Merged

fix: allow disabling all NSMenuItems #48712

Merged

trop bot added in-flight/38-x-y and removed target/38-x-y PR should also be added to the "38-x-y" branch. labels Oct 28, 2025

trop bot added in-flight/39-x-y in-flight/37-x-y and removed target/39-x-y PR should also be added to the "39-x-y" branch. target/37-x-y PR should also be added to the "37-x-y" branch. in-flight/39-x-y labels Oct 28, 2025

trop bot added a commit that referenced this pull request Nov 6, 2025

Revert "fix: allow disabling all NSMenuItems (#48598)"

2a7aede

This reverts commit 0cb4fdd. Co-authored-by: Keeley Hammond <khammond@slack-corp.com>

trop bot mentioned this pull request Nov 6, 2025

fix: revert allow disabling all NSMenuItems, fix menu crash #48801

Merged

trop bot added a commit that referenced this pull request Nov 6, 2025

Revert "fix: allow disabling all NSMenuItems (#48598)"

6e4dbd6

This reverts commit 0cb4fdd. Co-authored-by: Keeley Hammond <khammond@slack-corp.com>

trop bot mentioned this pull request Nov 6, 2025

fix: revert allow disabling all NSMenuItems, fix menu crash #48803

Merged

trop bot added a commit that referenced this pull request Nov 7, 2025

fix: allow disabling all NSMenuItems (#48598)

2f5a1b1

fix: allow disabling all NSMenuItems Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

trop bot added a commit that referenced this pull request Nov 7, 2025

fix: allow disabling all NSMenuItems (#48598)

2dfd8b8

fix: allow disabling all NSMenuItems Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

trop bot added a commit that referenced this pull request Nov 7, 2025

fix: allow disabling all NSMenuItems (#48598)

fbac570

fix: allow disabling all NSMenuItems Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

nilayarya pushed a commit to nilayarya/electron that referenced this pull request Nov 21, 2025

fix: allow disabling all NSMenuItems (electron#48598)

99c1deb

fix: allow disabling all NSMenuItems

nilayarya pushed a commit to nilayarya/electron that referenced this pull request Nov 21, 2025

fix: revert allow disabling all NSMenuItems, fix menu crash (electron…

2f99177

…#48794) Revert "fix: allow disabling all `NSMenuItems` (electron#48598)" This reverts commit 0cb4fdd.

nilayarya added a commit to nilayarya/electron that referenced this pull request Nov 21, 2025

fix: allow disabling all NSMenuItems (electron#48598)

5945894

fix: allow disabling all NSMenuItems

nilayarya added a commit to nilayarya/electron that referenced this pull request Nov 21, 2025

fix: revert allow disabling all NSMenuItems, fix menu crash (electron…

ef28b30

…#48794) Revert "fix: allow disabling all `NSMenuItems` (electron#48598)" This reverts commit 0cb4fdd.

nilayarya added a commit to nilayarya/electron that referenced this pull request Nov 21, 2025

fix: allow disabling all NSMenuItems (electron#48598)

c32564d

fix: allow disabling all NSMenuItems

nilayarya added a commit to nilayarya/electron that referenced this pull request Nov 21, 2025

fix: revert allow disabling all NSMenuItems, fix menu crash (electron…

41e6c38

…#48794) Revert "fix: allow disabling all `NSMenuItems` (electron#48598)" This reverts commit 0cb4fdd.

nikwen mentioned this pull request Jan 27, 2026

MenuItem accelerators broken after toggling enabled on macOS #49549

Closed

3 tasks

codebytere mentioned this pull request Jan 28, 2026

fix: macOS menu item accelerators when item disabled #49553

Merged

3 tasks

AlekseyManetov mentioned this pull request Feb 18, 2026

MenuItem accelerators fire even with enabled: false action #49841

Closed

3 tasks

codebytere mentioned this pull request Feb 19, 2026

fix: refresh menu item state on key equivalent dispatch #49875

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: allow disabling all `NSMenuItems`#48598

fix: allow disabling all `NSMenuItems`#48598
jkleinsc merged 1 commit intomainfrom
fix-enabled

codebytere commented Oct 20, 2025

Uh oh!

nikwen commented Oct 23, 2025

Uh oh!

Uh oh!

release-clerk bot commented Oct 28, 2025

Uh oh!

trop bot commented Oct 28, 2025

Uh oh!

trop bot commented Oct 28, 2025

Uh oh!

trop bot commented Oct 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

codebytere commented Oct 20, 2025

Description of Change

Checklist

Release Notes

Uh oh!

nikwen commented Oct 23, 2025

Uh oh!

Uh oh!

release-clerk bot commented Oct 28, 2025

Uh oh!

trop bot commented Oct 28, 2025

Uh oh!

trop bot commented Oct 28, 2025

Uh oh!

trop bot commented Oct 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants