Skip to content

ci: fix capturing fatal errors in clang problem matcher#51651

Merged
jkleinsc merged 1 commit into
mainfrom
ci/fix-clang-problem-matcher-fatal-errors
May 19, 2026
Merged

ci: fix capturing fatal errors in clang problem matcher#51651
jkleinsc merged 1 commit into
mainfrom
ci/fix-clang-problem-matcher-fatal-errors

Conversation

@dsanders11
Copy link
Copy Markdown
Member

Description of Change

Follow-up to #50984. That approach was incomplete because the value captured by the 4th capture group is what GitHub uses as the annotation level, and "fatal error" was being captured and not recognized by GitHub. So swap things around a bit so that only "error" is captured as the level.

Checklist

Release Notes

Notes: none

@dsanders11 dsanders11 added semver/none target/40-x-y PR should also be added to the "40-x-y" branch. target/41-x-y PR should also be added to the "41-x-y" branch. target/42-x-y PR should also be added to the "42-x-y" branch. target/43-x-y PR should also be added to the "43-x-y" branch. labels May 15, 2026
@jkleinsc jkleinsc merged commit 3f3be9e into main May 19, 2026
89 checks passed
@jkleinsc jkleinsc deleted the ci/fix-clang-problem-matcher-fatal-errors branch May 19, 2026 21:08
@release-clerk
Copy link
Copy Markdown

release-clerk Bot commented May 19, 2026

No Release Notes

@trop
Copy link
Copy Markdown
Contributor

trop Bot commented May 19, 2026

I have automatically backported this PR to "43-x-y", please check out #51710

@trop
Copy link
Copy Markdown
Contributor

trop Bot commented May 19, 2026

I have automatically backported this PR to "42-x-y", please check out #51711

@trop
Copy link
Copy Markdown
Contributor

trop Bot commented May 19, 2026

I have automatically backported this PR to "40-x-y", please check out #51712

@trop
Copy link
Copy Markdown
Contributor

trop Bot commented May 19, 2026

I have automatically backported this PR to "41-x-y", please check out #51713

@trop trop Bot added in-flight/42-x-y in-flight/40-x-y in-flight/41-x-y merged/43-x-y PR was merged to the "43-x-y" branch. and removed target/43-x-y PR should also be added to the "43-x-y" branch. target/42-x-y PR should also be added to the "42-x-y" branch. target/40-x-y PR should also be added to the "40-x-y" branch. target/41-x-y PR should also be added to the "41-x-y" branch. in-flight/43-x-y in-flight/40-x-y labels May 19, 2026
@trop trop Bot added merged/40-x-y PR was merged to the "40-x-y" branch. merged/42-x-y PR was merged to the "42-x-y" branch. merged/41-x-y PR was merged to the "41-x-y" branch. and removed in-flight/42-x-y in-flight/41-x-y labels May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged/40-x-y PR was merged to the "40-x-y" branch. merged/41-x-y PR was merged to the "41-x-y" branch. merged/42-x-y PR was merged to the "42-x-y" branch. merged/43-x-y PR was merged to the "43-x-y" branch. semver/none

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants