Skip to content

chore: cherry-pick d73358403b31 from chromium - #52601

Merged
jkleinsc merged 2 commits into
42-x-yfrom
cp-devtools-emulation-42
Aug 3, 2026
Merged

chore: cherry-pick d73358403b31 from chromium#52601
jkleinsc merged 2 commits into
42-x-yfrom
cp-devtools-emulation-42

Conversation

@codebytere

@codebytere codebytere commented Aug 3, 2026

Copy link
Copy Markdown
Member

Description of Change

Cherry-picks the upstream fix for a null dereference in DevToolsEmulator::DisableDeviceEmulation when the page's main frame is not local (crbug.com/411541676). The fix landed on Chromium main for M149; 42-x-y is on M148, so it needs the patch here.

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • tests are changed or added
  • relevant documentation, tutorials, templates and examples are changed or are not needed

Release Notes

Notes: Fixed a renderer crash when disabling device emulation while the main frame was not local.

Fixes a null dereference in DevToolsEmulator::DisableDeviceEmulation
when the page's main frame is not local (crbug.com/411541676, fixed
upstream for M149).
@codebytere
codebytere requested a review from a team as a code owner August 3, 2026 02:59
@electron-cation electron-cation Bot added the new-pr 🌱 PR opened recently label Aug 3, 2026
@codebytere codebytere added the backport-check-skip Skip trop's backport validity checking label Aug 3, 2026
@electron-cation electron-cation Bot removed the new-pr 🌱 PR opened recently label Aug 3, 2026
@codebytere codebytere added backport This is a backport PR new-pr 🌱 PR opened recently 42-x-y labels Aug 3, 2026
@electron-cation electron-cation Bot removed the new-pr 🌱 PR opened recently label Aug 3, 2026

@deepak1556 deepak1556 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a patch update

@jkleinsc jkleinsc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch needs update

@codebytere
codebytere requested a review from jkleinsc August 3, 2026 18:41
@jkleinsc jkleinsc added the semver/patch backwards-compatible bug fixes label Aug 3, 2026
@jkleinsc
jkleinsc merged commit 6f90fc5 into 42-x-y Aug 3, 2026
72 checks passed
@release-clerk

release-clerk Bot commented Aug 3, 2026

Copy link
Copy Markdown

Release Notes Persisted

Fixed a renderer crash when disabling device emulation while the main frame was not local.

@jkleinsc
jkleinsc deleted the cp-devtools-emulation-42 branch August 3, 2026 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

42-x-y backport This is a backport PR backport-check-skip Skip trop's backport validity checking semver/patch backwards-compatible bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants