fix: don't let pending shell operations block app exit on Windows - #52897
Merged
Conversation
shell.openExternal(), shell.openPath() and shell.showItemInFolder() run ShellExecuteEx()/SHOpenFolderAndSelectItems() on a COM STA thread-pool task with the default SKIP_ON_SHUTDOWN behaviour. A SKIP_ON_SHUTDOWN task that has already started blocks ThreadPoolInstance::Shutdown(), and ShellExecuteEx() can block inside the OS for as long as Windows is showing UI for the request - for example the "you'll need a new app to open this link" dialog for a URL scheme with no registered handler. The result is that app.quit() never completes (the process lingers after 'quit' has fired) until the user dismisses that system dialog. Post these tasks with CONTINUE_ON_SHUTDOWN instead, matching Chrome's platform_util::OpenItem, which uses that trait for the same reason. The tasks only touch their bound arguments and OS APIs, so letting shutdown proceed while one is still blocked in the shell is safe. Fixes #52141. No-Verification-Needed: Windows-only source not built on this host; verified via Windows CI experiment Co-authored-by: Sam Attard <sattard@anthropic.com>
3 tasks
trop
Bot
added
43-x-y
backport
MarshallOfSound
approved these changes
Aug 17, 2026
MarshallOfSound
enabled auto-merge (squash)
August 17, 2026 08:13
MarshallOfSound
deleted the
trop/43-x-y-bp-fix-don-t-let-pending-shell-operations-block-app-exit-on-windows-1786954322219
branch
August 17, 2026 09:45
|
Release Notes Persisted
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #52888
See that PR for details.
Notes: Fixed an issue on Windows where the app process could fail to exit after
app.quit()while ashell.openExternal()orshell.openPath()call was still waiting on a system "Open with" dialog.