build: set macOS native-module gypi values from config.gypi - #53532
Merged
MarshallOfSound merged 2 commits intoSep 4, 2026
Conversation
Emit clang=1 and MACOSX_DEPLOYMENT_TARGET=13.0 for OS==mac from generate-config-gypi.py (variables.conditions / target_conditions) instead of patching node's common.gypi, and write config.gypi as JSON so node-gyp's parser keeps the condition strings. Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
3 tasks
MarshallOfSound
approved these changes
Sep 4, 2026
MarshallOfSound
deleted the
trop/44-x-y-bp-build-set-macos-native-module-gypi-values-from-config-gypi-1788540400058
branch
September 4, 2026 18:30
|
No Release Notes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #53525
See that PR for details.
Notes: none