refactor: hand crashpad env to run-as-node children from lib/node/init - #53581
Merged
Conversation
Wrap internal/child_process's ChildProcess.prototype.spawn and spawnSync in lib/node/init.ts to add CRASHDUMP_SIGNAL_FD / CRASHPAD_HANDLER_PID for ELECTRON_RUN_AS_NODE children of process.execPath on Linux, replacing the patch to Node's normalizeSpawnArguments(). Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
parallel/test-child-process-constructor calls ChildProcess.prototype.spawn with non-object options and non-array envPairs and expects Node's own errors. Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
4 tasks
MarshallOfSound
approved these changes
Sep 5, 2026
|
No Release Notes |
MarshallOfSound
deleted the
trop/44-x-y-bp-refactor-hand-crashpad-env-to-run-as-node-children-from-lib-node-init-1788598842859
branch
September 5, 2026 14:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #53527
See that PR for details.
Notes: none