chore: keep data: URLs out of the non-standard scheme origin patch - #53681
Open
trop[bot] wants to merge 1 commit into
Open
Conversation
fix_crash_loading_non-standard_schemes_in_iframes.patch short-circuits origin computation for every non-standard URL so subframes on embedder-registered custom schemes do not trip CanAccessDataForOrigin. data: is also non-standard, so those navigations were taking the Electron branch too and skipping the nonce caching and initiator precursor upstream applies to data: URLs (crrev.com/c/4902624). Exclude data: in both the browser and renderer hunks so they stay on Chromium's path and the two sides keep agreeing. Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #53667
See that PR for details.
Notes: none