fix: add Electron 44 version gates for win32/ia32 and linux/armv7l - #1935
Merged
Conversation
Electron removed win32/ia32 and linux/armv7l builds starting with v44.0.0-alpha.4 (electron/electron#51816). Add upper bounds to the buildVersions map so that: - arch=all no longer expands to ia32/armv7l for Electron >= 44.0.0-alpha.4 - an explicit ia32/armv7l target produces the friendly "official support only exists" warning instead of a download 404 The bound is anchored at 44.0.0-alpha.4 (not 44.0.0) because officialBuildExists uses semver.satisfies with includePrerelease: true, so '<44.0.0' would still match the 44.0.0 prereleases that no longer ship these builds. Electron <= 43 behavior is unchanged. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KEEZg64JKFrSDAc7u4V4Na
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KEEZg64JKFrSDAc7u4V4Na
dsanders11
approved these changes
Jul 22, 2026
dsanders11
marked this pull request as ready for review
July 22, 2026 01:18
malept
reviewed
Jul 22, 2026
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KEEZg64JKFrSDAc7u4V4Na
malept
approved these changes
Jul 22, 2026
malept
left a comment
malept
left a comment
Member
There was a problem hiding this comment.
The other faux footnote (about macOS signing) should also be converted but that can happen in a follow up PR
|
🎉 This PR is included in version 20.0.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Samuel Attard, David Sanders · Slack thread
yarn lintand the targets spec pass; the full suite needs Electron binary downloads, which are unavailable in this environment)Summarize your changes:
Before: running
electron-packager --arch=ia32 --platform=win32(or--arch=armv7l --platform=linux) against Electron ≥ 44.0.0-alpha.4 fails with a confusing download 404, because Electron stopped publishing win32/ia32 and linux/armv7l builds in that release (electron/electron#51816).--arch=allalso tried (and failed) to package those architectures.After:
--arch=allsimply skips ia32/armv7l for Electron ≥ 44.0.0-alpha.4, and an explicit ia32/armv7l target prints the friendlyOfficial win32/ia32 support only exists in Electron <44.0.0-alpha.4warning (same as the existing linux/ia32 and mips64el gates) instead of a 404.How: adds
ia32: '<44.0.0-alpha.4'(win32) andarmv7l: '<44.0.0-alpha.4'(linux) to thebuildVersionsmap insrc/targets.ts, mirroring the existing linux/ia32 entry, plus tests and a README footnote. Behavior for Electron ≤ 43 is unchanged — those lines keep shipping 32-bit builds until v43 EOL. The upper bound is anchored at44.0.0-alpha.4rather than44.0.0becauseofficialBuildExistscallssemver.satisfieswithincludePrerelease: true, so<44.0.0would still match44.0.0-alpha.4+ prereleases, which no longer have these builds (44.0.0-alpha.1–3 and nightlies ≤ 20260706 still do).Generated by Claude Code