feat: invalid backports are neutral instead of failure#146
Closed
nornagon wants to merge 1 commit intoelectron:masterfrom
Closed
feat: invalid backports are neutral instead of failure#146nornagon wants to merge 1 commit intoelectron:masterfrom
nornagon wants to merge 1 commit intoelectron:masterfrom
Conversation
codebytere
reviewed
Apr 3, 2020
Member
|
(Closing as we are using the label now) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Marking the build failed because it's missing a backport annotation obscures the CI status in the PR list, and there are many valid reasons to have PRs targeting non-master branches that aren't direct backports.
Most recently: electron/electron#22943