Skip to content

fix: prevent blank GitHub widget previews - #241

Merged
bobleesj merged 1 commit into
electronmicroscopy:mainfrom
bobleesj:fix/github-nonblank-previews
Sep 4, 2026
Merged

fix: prevent blank GitHub widget previews#241
bobleesj merged 1 commit into
electronmicroscopy:mainfrom
bobleesj:fix/github-nonblank-previews

Conversation

@bobleesj

@bobleesj bobleesj commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

What problem does it solve?

GitHub and VS Code notebook exports could publish a blank WebGPU canvas because the exporter checked only that a canvas existed. The resulting preview hid the scientific image while leaving the surrounding widget controls visible.

What should reviewer(s) do?

Review the preview selection and pixel-content gate in src/quantem/widget/cli.py, then the focused blank-canvas and static-preview tests in tests/test_cli.py. The change affects quantem github export behavior only and does not change the public Python API.

Verification

  • python -m pytest -q tests/test_cli.py: 74 passed with the source checkouts on PYTHONPATH.
  • Six downstream Denova tutorial exports rendered nonblank scientific previews and retained unchanged source cells.
  • The committed diff passed git diff --check and the outgoing privacy scrub.

This PR follows the
scikit-package workflow for
reproducible scientific software.

@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
  • Delete bobleesj/quantem.widget:fix/github-nonblank-previews from its remote if you own it, it is not long-lived, and no other PR uses it.
  • Remove the dedicated worktree and local fix/github-nonblank-previews branch after confirming the worktree is clean.
  • Fetch electronmicroscopy/quantem.widget and update local main before starting new work.

@bobleesj
bobleesj merged commit dc95e02 into electronmicroscopy:main Sep 4, 2026
4 checks passed
@bobleesj
bobleesj deleted the fix/github-nonblank-previews branch September 4, 2026 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant